[dev-overlay] Remove unused onError in /pages

Every implementation is a no-op and we don't have
any plans.
Can use the same pattern as App Router when we need it.

Author: eps1lon

packages/next/src/client/components/react-dev-overlay/pages/hooks.ts

@@ -27,16 +27,8 @@ export const usePagesDevOverlay = () => {
     }
   }, [dispatch])
 
-  const onComponentError = React.useCallback(
-    (_error: Error, _componentStack: string | null) => {
-      // TODO: special handling
-    },
-    []
-  )
-
   return {
     state,
-    onComponentError,
     dispatch,
   }
 }

packages/next/src/client/components/react-dev-overlay/pages/pages-dev-overlay-error-boundary.tsx

@@ -2,7 +2,6 @@ import React from 'react'
 
 type PagesDevOverlayErrorBoundaryProps = {
   children?: React.ReactNode
-  onError: (error: Error, componentStack: string | null) => void
 }
 type PagesDevOverlayErrorBoundaryState = { error: Error | null }
 
@@ -16,13 +15,7 @@ export class PagesDevOverlayErrorBoundary extends React.PureComponent<
     return { error }
   }
 
-  componentDidCatch(
-    error: Error,
-    // Loosely typed because it depends on the React version and was
-    // accidentally excluded in some versions.
-    errorInfo?: { componentStack?: string | null }
-  ) {
-    this.props.onError(error, errorInfo?.componentStack || null)
+  componentDidCatch(error: Error) {
     this.setState({ error })
   }
 

packages/next/src/client/components/react-dev-overlay/pages/pages-dev-overlay.tsx

@@ -12,11 +12,11 @@ interface PagesDevOverlayProps {
 }
 
 export function PagesDevOverlay({ children }: PagesDevOverlayProps) {
-  const { state, dispatch, onComponentError } = usePagesDevOverlay()
+  const { state, dispatch } = usePagesDevOverlay()
 
   return (
     <>
-      <PagesDevOverlayErrorBoundary onError={onComponentError}>
+      <PagesDevOverlayErrorBoundary>
         {children ?? null}
       </PagesDevOverlayErrorBoundary>