Skip to content

Commit d1681f2

Browse files
authored
Revert "Run nightly bundler integration tests also with React 18" (#76640)
Reverts #76606 Causes the nightly jobs to fail with: ``` Error: Failed to CreateArtifact: Received non-retryable error: Failed request: (409) Conflict: an artifact with this name already exists on the workflow run ``` because we're running two `build_reusable` jobs with the same stepName. While I could fix this, we'd still have problems with either duplicating tests on areweturboyet, or we'd need some logic to merge test results across the matrix. I like the idea of running the full matrix, but this type of thing is rare and maybe not worth solving for (aside from catching it when the PR goes up, which we now have logic for, thanks to @unstubbable).
1 parent d75dbd3 commit d1681f2

File tree

1 file changed

+0
-6
lines changed

1 file changed

+0
-6
lines changed

.github/workflows/integration_tests_reusable.yml

-6
Original file line numberDiff line numberDiff line change
@@ -86,16 +86,13 @@ jobs:
8686
fail-fast: false
8787
matrix:
8888
group: ${{ fromJSON(needs.generate-matrices.outputs.e2e) }}
89-
# Empty value uses default
90-
react: ['', '18.3.1']
9189
uses: ./.github/workflows/build_reusable.yml
9290
with:
9391
afterBuild: |
9492
# e2e and ${{ inputs.test_type }} tests with `node run-tests.js`
9593
9694
export NEXT_TEST_CONTINUE_ON_ERROR=TRUE
9795
export NEXT_E2E_TEST_TIMEOUT=240000
98-
export NEXT_TEST_REACT_VERSION=${{ matrix.react }}
9996
export NEXT_TEST_MODE=${{
10097
inputs.test_type == 'development' && 'dev' || 'start'
10198
}}
@@ -122,8 +119,6 @@ jobs:
122119
fail-fast: false
123120
matrix:
124121
group: ${{ fromJSON(needs.generate-matrices.outputs.integration) }}
125-
# Empty value uses default
126-
react: ['', '18.3.1']
127122
uses: ./.github/workflows/build_reusable.yml
128123
with:
129124
nodeVersion: 18.18.2
@@ -132,7 +127,6 @@ jobs:
132127
133128
export NEXT_TEST_CONTINUE_ON_ERROR=TRUE
134129
export NEXT_E2E_TEST_TIMEOUT=240000
135-
export NEXT_TEST_REACT_VERSION=${{ matrix.react }}
136130
137131
# HACK: Despite the name, these environment variables are just used to
138132
# gate tests, so they're applicable to both turbopack and rspack tests

0 commit comments

Comments
 (0)