Skip to content

Commit f81ba18

Browse files
authored
Run nightly bundler integration tests also with React 18 (#76606)
While #76544 doesn't hurt, this is the more important fix to ensure that tests that were previously marked as `failed` are only promoted to `passed` if they also pass when the test is run with React 18.
1 parent 69116fd commit f81ba18

File tree

1 file changed

+6
-0
lines changed

1 file changed

+6
-0
lines changed

.github/workflows/integration_tests_reusable.yml

+6
Original file line numberDiff line numberDiff line change
@@ -86,13 +86,16 @@ jobs:
8686
fail-fast: false
8787
matrix:
8888
group: ${{ fromJSON(needs.generate-matrices.outputs.e2e) }}
89+
# Empty value uses default
90+
react: ['', '18.3.1']
8991
uses: ./.github/workflows/build_reusable.yml
9092
with:
9193
afterBuild: |
9294
# e2e and ${{ inputs.test_type }} tests with `node run-tests.js`
9395
9496
export NEXT_TEST_CONTINUE_ON_ERROR=TRUE
9597
export NEXT_E2E_TEST_TIMEOUT=240000
98+
export NEXT_TEST_REACT_VERSION=${{ matrix.react }}
9699
export NEXT_TEST_MODE=${{
97100
inputs.test_type == 'development' && 'dev' || 'start'
98101
}}
@@ -119,6 +122,8 @@ jobs:
119122
fail-fast: false
120123
matrix:
121124
group: ${{ fromJSON(needs.generate-matrices.outputs.integration) }}
125+
# Empty value uses default
126+
react: ['', '18.3.1']
122127
uses: ./.github/workflows/build_reusable.yml
123128
with:
124129
nodeVersion: 18.18.2
@@ -127,6 +132,7 @@ jobs:
127132
128133
export NEXT_TEST_CONTINUE_ON_ERROR=TRUE
129134
export NEXT_E2E_TEST_TIMEOUT=240000
135+
export NEXT_TEST_REACT_VERSION=${{ matrix.react }}
130136
131137
# HACK: Despite the name, these environment variables are just used to
132138
# gate tests, so they're applicable to both turbopack and rspack tests

0 commit comments

Comments
 (0)