Improve JSON Parsing Error Handling in parse_hedge_fund_response() in main.py

[yashar1908]

The function parse_hedge_fund_response(response) currently has a broad except: clause that catches all exceptions, including those unrelated to JSON parsing. This can lead to:

• Hiding real errors (e.g., None being passed instead of valid JSON).
• Making debugging harder by suppressing detailed error messages.
• Unexpected behavior when the function silently fails and returns None without logging the root cause.

Current Implementation of the function:

Proposed Fix:

Expected Improvement:
Narrows down on classifying variety of errors providing more information into the issue.

[yashar1908]

import json

def parse_hedge_fund_response(response):
    """Parses a JSON string and returns a dictionary."""
    try:
        return json.loads(response)
    except json.JSONDecodeError as e:
        print(f"JSON decoding error: {e}\nResponse: {response}")
        return None
    except TypeError as e:
        print(f"Invalid response type (expected string, got {type(response).__name__}): {e}")
        return None
    except Exception as e:
        print(f"Unexpected error while parsing response: {e}")
        return None

[virattt]

This is a great idea @yashar1908 - can you create a Pull Request?

[yashar1908]

Sure, I will go ahead and do that, thanks.

[Varun786223]

@yashar1908 @virattt

Hi Yashar, fantastic work catching this—your update to parse_hedge_fund_response() is a real improvement! Switching from that broad except to specific JSONDecodeError, TypeError, and Exception handlers with clear logs is spot-on—makes tracking down issues so much easier. I threw a bunch of test cases at it (good JSON, mangled JSON, None, empty strings, numbers), and it holds up perfectly—no bugs I could spot.

I’ve got a small tweak to contribute for the PR—swapping print() for logging, capping the response in logs for safety, and tidying the docstring. Here’s what I’m suggesting:
`python

import json
import logging

logger = logging.getLogger(name)

def parse_hedge_fund_response(response):
"""Parses a JSON string and returns a dictionary.

Args:
    response: A JSON-formatted string to parse.

Returns:
    dict: Parsed JSON data, or None if parsing fails.
"""
try:
    return json.loads(response)
except json.JSONDecodeError as e:
    logger.error("JSON decoding failed: %s | Response (truncated): %s", e, str(response)[:50])
    return None
except TypeError as e:
    logger.error("Invalid response type, expected string, got %s: %s", type(response).__name__, e)
    return None
except Exception as e:
    logger.error("Unexpected error parsing response: %s", e)
    return None`

This keeps your core fix, Yashar, but adds a proper logger for production, limits logged response to 50 chars to avoid leaks, and sharpens the docs. Virattt, this should make it more robust—any thoughts on including it?

Yashar, happy to team up on the PR—could toss this in with a quick test (like None or bad JSON) to seal the deal. Great catch again—let me know how I can help get this over the line! Looking forward to cleaning this up together!