Skip to content

Inputs - Keyboard Shortcuts #163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
garv-shah opened this issue Nov 6, 2022 · 2 comments
Closed

Inputs - Keyboard Shortcuts #163

garv-shah opened this issue Nov 6, 2022 · 2 comments
Assignees

Comments

@garv-shah
Copy link

Flutter Quill recently had some commits that added support for keyboard shortcuts such as ctrl + b allowing a user to bold text. The quality of the PR doesn't seem to be the best but similar functionality could possibly also be considered for Visual Editor.

Another PR that adds typing shortcuts was also pushed here

Thanks!

@adrian-moisa
Copy link
Collaborator

Hey @garv-shah! Thanks for sharing this info. To be honest, I've been tracking Quill to see where it goes and I've already took notes of the interesting developments that we want to port over here, including this particular feature. Actually this feature will be essential for the next step: slash commands, mentions, hashtags.

There was a learning period involved so I couldn't focus at all on keeping features parity. But by now I'm familiar with 90% of the code base and also have a few people helping around that are catching up. So we will keep improving the editor. I'm going trough the entire tickets list to weed out the duplicates, improve the specs and also add these additional ideas in the tickets list.

@adrian-moisa adrian-moisa changed the title Support for Keyboard Shortcuts Inputs - Support for Keyboard Shortcuts Nov 6, 2022
@adrian-moisa adrian-moisa changed the title Inputs - Support for Keyboard Shortcuts Inputs - Keyboard Shortcuts Nov 6, 2022
@darius859 darius859 self-assigned this Nov 17, 2022
@darius859
Copy link
Collaborator

Added hotkeys for most of the styling buttons inside the toolbar, also added handling for inserting ordered and unordered lists by typing either "1. " or "-" + spacebar. Did it in a much cleaner way. Created a service for typing shortcuts (TypingShortcutsService) which handles spacebar and tab key when pressed alone or with some text combination like above. Also created a shortcuts utils for applying styling attributes (e.g. CTRL + B applies bold to selection).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants