-
Notifications
You must be signed in to change notification settings - Fork 48
Sys - Remove Tuple package dependency #45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
When I start working on visual-editor, I had difficulty cloning the repo and running the demo so I made a tutorial to help other users who want to contribute:
It can be found also in the README.md |
Congrats! Great work on this ticket! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Atm, there is a dependency to the tuple package which I think should be either removed or should be exposed so visual-editor users won't have to import the tuple package as well. I add to import the package manually to edit the lineSpacing for instance:
This seems to have been used a lot in the package. However, having a Tuple instead of a concrete class makes the implementation quite obscure. Here for instance, I don't see why the lineSpacing is not a simple double instead of a Tuple.
The text was updated successfully, but these errors were encountered: