fix(hmr): do not update on file unlink when there are no affected modules (#1818)

CHOYSEN · web-flow · commit 59fe913f1226 · 2021-01-30T13:52:02.000-05:00
diff --git a/packages/vite/src/node/server/hmr.ts b/packages/vite/src/node/server/hmr.ts
@@ -174,12 +174,14 @@ export async function handleFileAddUnlink(
         modules.push(module)
       }
     }
-    updateModules(
-      getShortName(file, server.config.root),
-      modules,
-      Date.now(),
-      server
-    )
+    if (modules.length > 0) {
+      updateModules(
+        getShortName(file, server.config.root),
+        modules,
+        Date.now(),
+        server
+      )
+    }
   }
 }
 

Original file line number	Diff line number	Diff line change
`@@ -174,12 +174,14 @@ export async function handleFileAddUnlink(`
`174`	`174`	`modules.push(module)`
`175`	`175`	`}`
`176`	`176`	`}`
`177`		`- updateModules(`
`178`		`- getShortName(file, server.config.root),`
`179`		`- modules,`
`180`		`- Date.now(),`
`181`		`- server`
`182`		`- )`
	`177`	`+ if (modules.length > 0) {`
	`178`	`+ updateModules(`
	`179`	`+ getShortName(file, server.config.root),`
	`180`	`+ modules,`
	`181`	`+ Date.now(),`
	`182`	`+ server`
	`183`	`+ )`
	`184`	`+ }`
`183`	`185`	`}`
`184`	`186`	`}`
`185`	`187`