Skip to content

Commit 5c55b29

Browse files
authored
fix(mergeConfig): don't recreate server.hmr.server instance (#17763)
1 parent e408542 commit 5c55b29

File tree

2 files changed

+16
-0
lines changed

2 files changed

+16
-0
lines changed

packages/vite/src/node/__tests__/config.spec.ts

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
import http from 'node:http'
12
import { describe, expect, test } from 'vitest'
23
import type { InlineConfig } from '..'
34
import type { PluginOption, UserConfig, UserConfigExport } from '../config'
@@ -185,6 +186,18 @@ describe('mergeConfig', () => {
185186
expect(mergeConfig(newConfig, baseConfig)).toEqual(mergedConfig)
186187
})
187188

189+
test('handles server.hmr.server', () => {
190+
const httpServer = http.createServer()
191+
192+
const baseConfig = { server: { hmr: { server: httpServer } } }
193+
const newConfig = { server: { hmr: { server: httpServer } } }
194+
195+
const mergedConfig = mergeConfig(baseConfig, newConfig)
196+
197+
// Server instance should not be recreated
198+
expect(mergedConfig.server.hmr.server).toBe(httpServer)
199+
})
200+
188201
test('throws error with functions', () => {
189202
const baseConfig = defineConfig(() => ({ base: 'base' }))
190203
const newConfig = defineConfig(() => ({ base: 'new' }))

packages/vite/src/node/utils.ts

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1110,6 +1110,9 @@ function mergeConfigRecursively(
11101110
...backwardCompatibleWorkerPlugins(value),
11111111
]
11121112
continue
1113+
} else if (key === 'server' && rootPath === 'server.hmr') {
1114+
merged[key] = value
1115+
continue
11131116
}
11141117

11151118
if (Array.isArray(existing) || Array.isArray(value)) {

0 commit comments

Comments
 (0)