Skip to content

Commit a1f8082

Browse files
authored
chore: use eslint-plugin-i (#15569)
1 parent 0fb9071 commit a1f8082

File tree

12 files changed

+29
-514
lines changed

12 files changed

+29
-514
lines changed

Diff for: .eslintrc.cjs

+5-6
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@ const { defineConfig } = require('eslint-define-config')
44
const pkg = require('./package.json')
55

66
/// <reference types="@eslint-types/typescript-eslint" />
7-
/// <reference types="@eslint-types/import" />
87

98
module.exports = defineConfig({
109
root: true,
@@ -16,7 +15,7 @@ module.exports = defineConfig({
1615
'plugin:regexp/recommended',
1716
],
1817
ignorePatterns: ['packages/create-vite/template-**'],
19-
plugins: ['import', 'regexp'],
18+
plugins: ['i', 'regexp'],
2019
parser: '@typescript-eslint/parser',
2120
parserOptions: {
2221
sourceType: 'module',
@@ -93,12 +92,12 @@ module.exports = defineConfig({
9392
'@typescript-eslint/prefer-for-of': 'off',
9493
'@typescript-eslint/prefer-function-type': 'off',
9594

96-
'import/no-nodejs-modules': [
95+
'i/no-nodejs-modules': [
9796
'error',
9897
{ allow: builtinModules.map((mod) => `node:${mod}`) },
9998
],
100-
'import/no-duplicates': 'error',
101-
'import/order': 'error',
99+
'i/no-duplicates': 'error',
100+
'i/order': 'error',
102101
'sort-imports': [
103102
'error',
104103
{
@@ -213,7 +212,7 @@ module.exports = defineConfig({
213212
'playground/tailwind/**', // blocked by https://github.com/postcss/postcss-load-config/issues/239
214213
],
215214
rules: {
216-
'import/no-commonjs': 'error',
215+
'i/no-commonjs': 'error',
217216
},
218217
},
219218
{

Diff for: package.json

+1-2
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,6 @@
4242
},
4343
"devDependencies": {
4444
"@babel/types": "^7.23.6",
45-
"@eslint-types/import": "^2.29.0-1",
4645
"@eslint-types/typescript-eslint": "^6.12.0",
4746
"@rollup/plugin-typescript": "^11.1.5",
4847
"@types/babel__core": "^7.20.5",
@@ -68,7 +67,7 @@
6867
"conventional-changelog-cli": "^4.1.0",
6968
"eslint": "^8.55.0",
7069
"eslint-define-config": "^2.0.0",
71-
"eslint-plugin-import": "^2.29.0",
70+
"eslint-plugin-i": "^2.29.1",
7271
"eslint-plugin-n": "^16.4.0",
7372
"eslint-plugin-regexp": "^2.1.2",
7473
"execa": "^8.0.1",

Diff for: playground/cli-module/vite.config.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
// eslint-disable-next-line import/no-nodejs-modules
1+
// eslint-disable-next-line i/no-nodejs-modules
22
import { URL } from 'url'
33
import { defineConfig } from 'vite'
44

Diff for: playground/css/main.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ import './layered/index.css'
4343
import './dep.css'
4444
import './glob-dep.css'
4545

46-
// eslint-disable-next-line import/order
46+
// eslint-disable-next-line i/order
4747
import { barModuleClasses } from '@vitejs/test-css-js-dep'
4848
document
4949
.querySelector('.css-js-dep-module')

Diff for: playground/js-sourcemap/importee-pkg/index.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,2 @@
1-
// eslint-disable-next-line import/no-commonjs
1+
// eslint-disable-next-line i/no-commonjs
22
exports.foo = 'foo'

Diff for: playground/object-hooks/vite.config.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
/* eslint-disable import/no-nodejs-modules */
1+
/* eslint-disable i/no-nodejs-modules */
22
import assert from 'assert'
33
import { defineConfig } from 'vite'
44

Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
'use strict'
22

3-
// eslint-disable-next-line import/no-nodejs-modules
3+
// eslint-disable-next-line i/no-nodejs-modules
44
const events = require('events')
55

66
module.exports = 'foo' in events ? 'pong' : ''

Diff for: playground/optimize-deps/dep-with-builtin-module-cjs/index.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
// no node: protocol intentionally
2-
// eslint-disable-next-line import/no-nodejs-modules
2+
// eslint-disable-next-line i/no-nodejs-modules
33
const fs = require('fs')
4-
// eslint-disable-next-line import/no-nodejs-modules
4+
// eslint-disable-next-line i/no-nodejs-modules
55
const path = require('path')
66

77
// NOTE: require destructure would error immediately because of how esbuild

Diff for: playground/optimize-deps/dep-with-builtin-module-esm/index.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
// no node: protocol intentionally
2-
// eslint-disable-next-line import/no-nodejs-modules
2+
// eslint-disable-next-line i/no-nodejs-modules
33
import { readFileSync } from 'fs'
4-
// eslint-disable-next-line import/no-nodejs-modules
4+
// eslint-disable-next-line i/no-nodejs-modules
55
import path from 'path'
66

77
// access from named import

Diff for: playground/resolve/browser-field/relative.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
/* eslint-disable import/no-duplicates */
1+
/* eslint-disable i/no-duplicates */
22
import ra from './no-ext'
33
import rb from './no-ext.js' // no substitution
44
import rc from './ext'
+1-1
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,2 @@
1-
/* eslint-disable import/no-commonjs */
1+
/* eslint-disable i/no-commonjs */
22
module.exports.msg = '[fail] exports with module condition (index.js)'

0 commit comments

Comments
 (0)