Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

valid-title no longer reports emptyTitle errors since v1.1.38 #687

Closed
y-hsgw opened this issue Apr 1, 2025 · 0 comments · Fixed by #688
Closed

valid-title no longer reports emptyTitle errors since v1.1.38 #687

y-hsgw opened this issue Apr 1, 2025 · 0 comments · Fixed by #688

Comments

@y-hsgw
Copy link
Contributor

y-hsgw commented Apr 1, 2025

Since upgrading to Vitest v1.1.38, the valid-title rule no longer reports emptyTitle errors. It seems to be a false negative, as empty titles are not flagged anymore.
This was working correctly in v1.1.37.

it('', () => { // Should report emptyTitle error, but doesn't
  expect(1).toBe(1);
});

eslint.config.js

{
 plugins: {
   vitest,
 },
 rules: {
   ...vitest.configs.recommended.rules,
 },
 settings: {
   vitest: {
     typecheck: true,
   },
 },
 languageOptions: {
   globals: {
     ...vitest.environments.env.globals,
   },
 },
},

Related PR: #682

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant