Skip to content

Commit 33f227e

Browse files
[CI/Build] Use a fixed seed to avoid flaky tests (#14480)
Signed-off-by: DarkLight1337 <[email protected]>
1 parent cfd0ae8 commit 33f227e

File tree

4 files changed

+7
-6
lines changed

4 files changed

+7
-6
lines changed

tests/entrypoints/openai/test_chat_echo.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,8 +24,6 @@ def server():
2424
"4080",
2525
"--chat-template",
2626
DUMMY_CHAT_TEMPLATE,
27-
"--seed",
28-
"0",
2927
]
3028

3129
with RemoteOpenAIServer(MODEL_NAME, args) as remote_server:

tests/entrypoints/openai/test_metrics.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -47,8 +47,6 @@ def default_server_args():
4747
"--enforce-eager",
4848
"--max-num-seqs",
4949
"128",
50-
"--seed",
51-
"0",
5250
]
5351

5452

tests/entrypoints/openai/test_root_path.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,8 +30,6 @@ def server():
3030
"/" + ROOT_PATH,
3131
"--chat-template",
3232
DUMMY_CHAT_TEMPLATE,
33-
"--seed",
34-
"0",
3533
]
3634
envs = os.environ.copy()
3735

tests/utils.py

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -76,6 +76,7 @@ def __init__(self,
7676
vllm_serve_args: list[str],
7777
*,
7878
env_dict: Optional[dict[str, str]] = None,
79+
seed: Optional[int] = 0,
7980
auto_port: bool = True,
8081
max_wait_seconds: Optional[float] = None) -> None:
8182
if auto_port:
@@ -87,6 +88,12 @@ def __init__(self,
8788
vllm_serve_args = vllm_serve_args + [
8889
"--port", str(get_open_port())
8990
]
91+
if seed is not None:
92+
if "--seed" in vllm_serve_args:
93+
raise ValueError("You have manually specified the seed "
94+
f"when `seed={seed}`.")
95+
96+
vllm_serve_args = vllm_serve_args + ["--seed", str(seed)]
9097

9198
parser = FlexibleArgumentParser(
9299
description="vLLM's remote OpenAI server.")

0 commit comments

Comments
 (0)