Skip to content

Commit cf5984b

Browse files
njhillkouroshHakha
andauthored
[BugFix][DP] Send DP wave completion only from dp_rank==0 (#18502)
Signed-off-by: Nick Hill <[email protected]> Co-authored-by: kourosh hakhamaneshi <[email protected]>
1 parent d022115 commit cf5984b

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

vllm/v1/engine/core.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -701,7 +701,7 @@ def _init_data_parallel(self, vllm_config: VllmConfig):
701701
for i in range(local_dp_rank * world_size, (local_dp_rank + 1) *
702702
world_size))
703703

704-
self.local_dp_rank = local_dp_rank
704+
self.dp_rank = dp_rank
705705
self.dp_group = vllm_config.parallel_config.stateless_init_dp_group()
706706
self.current_wave = 0
707707

@@ -774,7 +774,7 @@ def run_busy_loop(self):
774774
local_unfinished_reqs)
775775

776776
if not self.engines_running:
777-
if self.local_dp_rank == 0:
777+
if self.dp_rank == 0:
778778
# Notify client that we are pausing the loop.
779779
logger.debug("Wave %d finished, pausing engine loop.",
780780
self.current_wave)

0 commit comments

Comments
 (0)