Skip to content

Commit d3efde8

Browse files
authored
[Benchmarks] Remove invalid option under V1 engine (#17651)
Signed-off-by: Russell Bryant <[email protected]>
1 parent aea302b commit d3efde8

File tree

2 files changed

+3
-20
lines changed

2 files changed

+3
-20
lines changed

benchmarks/benchmark_serving_structured_output.py

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -414,7 +414,6 @@ async def benchmark(
414414
ignore_eos: bool,
415415
max_concurrency: Optional[int],
416416
structured_output_ratio: float,
417-
structured_output_backend: str,
418417
goodput_config_dict: Optional[dict[str, float]] = None,
419418
):
420419
if backend in ASYNC_REQUEST_FUNCS:
@@ -426,8 +425,6 @@ def prepare_extra_body(request) -> dict:
426425
extra_body = {}
427426
# Add the schema to the extra_body
428427
extra_body[request.structure_type] = request.schema
429-
# Add the specific structured_output_backend
430-
extra_body["guided_decoding_backend"] = structured_output_backend
431428
return extra_body
432429

433430
print("Starting initial single prompt test run...")
@@ -785,7 +782,6 @@ def main(args: argparse.Namespace):
785782
ignore_eos=args.ignore_eos,
786783
max_concurrency=args.max_concurrency,
787784
structured_output_ratio=args.structured_output_ratio,
788-
structured_output_backend=args.structured_output_backend,
789785
goodput_config_dict=goodput_config_dict,
790786
))
791787

@@ -1000,14 +996,6 @@ def main(args: argparse.Namespace):
1000996
type=float,
1001997
default=1.0,
1002998
help="Ratio of Structured Outputs requests")
1003-
parser.add_argument("--structured-output-backend",
1004-
type=str,
1005-
choices=[
1006-
"outlines", "lm-format-enforcer", "xgrammar",
1007-
"guidance", "auto"
1008-
],
1009-
default="auto",
1010-
help="Backend to use for structured outputs")
1011999

10121000
args = parser.parse_args()
10131001
main(args)

benchmarks/run_structured_output_benchmark.sh

Lines changed: 3 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -9,13 +9,10 @@ BACKEND=${2:-"vllm"}
99
# Define the dataset to use
1010
DATASET=${3:-"xgrammar_bench"}
1111

12-
# Define the guided decoding backend
13-
GUIDED_BACKEND=${4:-"xgrammar"}
14-
1512
SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
16-
OUTPUT_DIR=${5:-"$SCRIPT_DIR/structured_output_benchmark_results"}
13+
OUTPUT_DIR=${4:-"$SCRIPT_DIR/structured_output_benchmark_results"}
1714

18-
GUIDED_RATIO=${6:-0.5}
15+
GUIDED_RATIO=${5:-0.5}
1916

2017
# Create output directory if it doesn't exist
2118
mkdir -p "$OUTPUT_DIR"
@@ -27,15 +24,13 @@ QPS_VALUES=(70 60 50 25 20 15 10)
2724
COMMON_PARAMS="--backend $BACKEND \
2825
--model $MODEL \
2926
--dataset $DATASET \
30-
--structured-output-backend $GUIDED_BACKEND \
3127
--structured-output-ratio $GUIDED_RATIO \
3228
--save-results \
3329
--result-dir $OUTPUT_DIR"
3430

3531
echo "Starting structured output benchmark with model: $MODEL"
3632
echo "Backend: $BACKEND"
3733
echo "Dataset: $DATASET"
38-
echo "Structured output backend: $GUIDED_BACKEND"
3934
echo "Results will be saved to: $OUTPUT_DIR"
4035
echo "----------------------------------------"
4136

@@ -48,7 +43,7 @@ for qps in "${QPS_VALUES[@]}"; do
4843
GIT_BRANCH=$(git rev-parse --abbrev-ref HEAD 2>/dev/null || echo "unknown")
4944

5045
# Construct filename for this run
51-
FILENAME="${GUIDED_BACKEND}_${BACKEND}_${qps}qps_$(basename $MODEL)_${DATASET}_${GIT_HASH}.json"
46+
FILENAME="${BACKEND}_${qps}qps_$(basename $MODEL)_${DATASET}_${GIT_HASH}.json"
5247

5348
# Run the benchmark
5449
python "$SCRIPT_DIR/benchmark_serving_structured_output.py" $COMMON_PARAMS \

0 commit comments

Comments
 (0)