Skip to content

Commit e52d83d

Browse files
committed
[Build/CI] Add tracing deps to vllm container image
A report requested that these dependencies be included in the image for tracing. That seems reasonable - they are needed by `vllm.tracing`. Stop manually installing them in the relevant test pipeline and just include them in the image. Signed-off-by: Russell Bryant <[email protected]>
1 parent 69ae238 commit e52d83d

File tree

2 files changed

+4
-5
lines changed

2 files changed

+4
-5
lines changed

.buildkite/test-pipeline.yaml

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -156,11 +156,6 @@ steps:
156156
- tests/tracing
157157
commands:
158158
- pytest -v -s metrics
159-
- "pip install \
160-
'opentelemetry-sdk>=1.26.0,<1.27.0' \
161-
'opentelemetry-api>=1.26.0,<1.27.0' \
162-
'opentelemetry-exporter-otlp>=1.26.0,<1.27.0' \
163-
'opentelemetry-semantic-conventions-ai>=0.4.1,<0.5.0'"
164159
- pytest -v -s tracing
165160

166161
##### fast check tests #####

requirements/common.txt

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -41,3 +41,7 @@ watchfiles # required for http server to monitor the updates of TLS files
4141
python-json-logger # Used by logging as per examples/other/logging_configuration.md
4242
scipy # Required for phi-4-multimodal-instruct
4343
ninja # Required for xgrammar, rocm, tpu, xpu
44+
opentelemetry-sdk>=1.26.0,<1.27.0
45+
opentelemetry-api>=1.26.0,<1.27.0
46+
opentelemetry-exporter-otlp>=1.26.0,<1.27.0
47+
opentelemetry-semantic-conventions-ai>=0.4.1,<0.5.0

0 commit comments

Comments
 (0)