-
-
Notifications
You must be signed in to change notification settings - Fork 7.7k
[Bug]: Guided Decoding Backend options with the OpenAI server recently broken #17002
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Thanks for the bug report! Personally, I'd prefer to split this into at least two args rather than making one arg do two things. cc @joerunde whon added the |
If we change it, we should probably have a deprecation period where the previous format still works but raises a warning. Either way, I think the previous format needs to keep working for now. |
Here's a draft PR (unfinished) which would re-enable these options and keep the old format until we decide we can drop it #17008 |
Before I put more work into that PR, is everyone happy with that as a solution? Rather simply fixing the custom arg processing we had befoire? |
IMO, using an option string was a good quick-fix for |
👍 , yeah I was looking for the quick fix there and it seemed like a much better idea than adding more environment variables at the time. I agree we can change it to split out these options into a second list or dict, a dict would probably be more flexible in case we need key-value pairs in the future. I'm fine if we stick a warning on the existing string options now and delete that support in v0.9.0 |
Uh oh!
There was an error while loading. Please reload this page.
Your current environment
vLLM installed with:
🐛 Describe the bug
After merging #16789, using "options" for guided decoding backends no longer works. Attempting to include a backend option results in:
The new type checking of the args checks against a Literal type for the backend name, disallowing any options. For reference, backend options are briefly documented REF:
Note that there are a few backend options that can be combined like
guidance:disable-any-whitespace,no-fallback
, so simply adding entries to the list of Literals seems untenable. I encountered this bug when writing up a PR to add another option #15949.cc: @russellb @hmellor
Before submitting a new issue...
The text was updated successfully, but these errors were encountered: