Skip to content

[Bug]: Flash attention with sliding window #17476

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
1 task done
heheda12345 opened this issue Apr 30, 2025 · 1 comment · Fixed by #17574
Closed
1 task done

[Bug]: Flash attention with sliding window #17476

heheda12345 opened this issue Apr 30, 2025 · 1 comment · Fixed by #17574
Labels
bug Something isn't working

Comments

@heheda12345
Copy link
Collaborator

Your current environment

N/A

🐛 Describe the bug

pytest -vs test_correctness_sliding_window.py::test_sliding_window_retrival\[1-5-bigcode/starcoder2-3b\] starts to fail on H100 since #16998. This test can pass if I change it to num_heads_kv=self.num_heads_q like here https://github.com/heheda12345/vllm/tree/fa3_hack .

Before submitting a new issue...

  • Make sure you already searched for relevant issues, and asked the chatbot living at the bottom right corner of the documentation page, which can answer lots of frequently asked questions.
@heheda12345 heheda12345 added the bug Something isn't working label Apr 30, 2025
@heheda12345
Copy link
Collaborator Author

CC @LucasWilkinson

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant