Skip to content

[New Model]: Support Zyphra/Zamba2-7B #9382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
1 task done
mgoin opened this issue Oct 15, 2024 · 6 comments
Closed
1 task done

[New Model]: Support Zyphra/Zamba2-7B #9382

mgoin opened this issue Oct 15, 2024 · 6 comments
Labels
new-model Requests to new models unstale Recieved activity after being labelled stale

Comments

@mgoin
Copy link
Member

mgoin commented Oct 15, 2024

The model to consider.

Announcement blog: https://www.zyphra.com/post/zamba2-7b

Base model: https://huggingface.co/Zyphra/Zamba2-7B
Instruct tuned: https://huggingface.co/Zyphra/Zamba2-7B-Instruct

image

The closest model vllm already supports.

Jamba, as it is a mixture of state-space and transformers blocks

Zamba2-7B-Instruct is a hybrid model composed of state-space (Mamba2) and transformer blocks.

What's your difficulty of supporting the model you want?

Should be easy once Mamba2 support lands in #9292, however this use_shared_attention_lora case seems possibly complex

All of the HF-compatible modeling code can be found here: https://github.com/Zyphra/transformers_zamba2/tree/main/src/transformers/models/zamba2

Before submitting a new issue...

  • Make sure you already searched for relevant issues, and asked the chatbot living at the bottom right corner of the documentation page, which can answer lots of frequently asked questions.
@mgoin mgoin added the new-model Requests to new models label Oct 15, 2024
@yaronr
Copy link

yaronr commented Oct 16, 2024

+1

2 similar comments
@scwall
Copy link

scwall commented Oct 20, 2024

+1

@engchina
Copy link

+1

Copy link

This issue has been automatically marked as stale because it has not had any activity within 90 days. It will be automatically closed if no further activity occurs within 30 days. Leave a comment if you feel this issue should remain open. Thank you!

@github-actions github-actions bot added the stale Over 90 days of inactivity label Jan 30, 2025
@yury-tokpanov
Copy link
Contributor

Hey. Yury here from Zyphra. We have an internal version that works, going to open a PR sometime soon.

@github-actions github-actions bot added unstale Recieved activity after being labelled stale and removed stale Over 90 days of inactivity labels Feb 4, 2025
@yury-tokpanov
Copy link
Contributor

This is done now. Merged into 0.8.x version of vLLM

@hmellor hmellor closed this as completed Apr 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-model Requests to new models unstale Recieved activity after being labelled stale
Projects
None yet
Development

No branches or pull requests

6 participants