From 157c20dc029c9cbd9e58f060d5a6d9e9c1f1e13d Mon Sep 17 00:00:00 2001 From: Russell Bryant Date: Tue, 11 Feb 2025 16:50:17 -0500 Subject: [PATCH] [Misc] Move pre-commit suggestion back to the end This change moves the pre-commit suggestion back to the end of the pre-commit configuration. This entry emits a message about how to skip the pre-commit checks. Its better to have that at the end instead of the middle. I also included some comments to remind future editors of the file to keep this entry at the end. Signed-off-by: Russell Bryant --- .pre-commit-config.yaml | 16 +++++++++------- 1 file changed, 9 insertions(+), 7 deletions(-) diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml index 352eb2df01b..22b51afdc57 100644 --- a/.pre-commit-config.yaml +++ b/.pre-commit-config.yaml @@ -116,13 +116,6 @@ repos: language: python types: [python] exclude: 'vllm/third_party/.*' - - id: suggestion - name: Suggestion - entry: bash -c 'echo "To bypass pre-commit hooks, add --no-verify to git commit."' - language: system - verbose: true - pass_filenames: false - exclude: 'vllm/third_party/.*' - id: check-filenames name: Check for spaces in all filenames entry: bash @@ -133,3 +126,12 @@ repos: always_run: true pass_filenames: false exclude: 'vllm/third_party/.*' + # Keep `suggestion` last + - id: suggestion + name: Suggestion + entry: bash -c 'echo "To bypass pre-commit hooks, add --no-verify to git commit."' + language: system + verbose: true + pass_filenames: false + exclude: 'vllm/third_party/.*' + # Insert new entries above the `suggestion` entry