Skip to content

Commit be67535

Browse files
[SYCL][NFC] Drop on-device tests in favor of llvm-test-suite (intel#4393)
The original motivation for introducing on-device tests was two-fold: - Provide a way to test product changes together with E2E test changes for features in active development, these tests would then be moved to llvm-test-suite once the feature is considered stable. Frequently, instead of using on-device tests (or in case an existing llvm-test-suite test has to be modified) developers would create a pull request in each repo, link them via a comment, then they would be either merged simultaneously (while relying on local testing and intel/llvm post-commit results for the modified/added tests) or one after the other. - As a way to have some sanity E2E checks in intel/llvm. On-device tests haven't been used in this manner, we've been relying on component tests instead. This patch drops in-tree on-device tests in favor of llvm-test-suite in order to reduce in-tree test running time.
1 parent 0abdfd6 commit be67535

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

45 files changed

+1
-4045
lines changed

CONTRIBUTING.md

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -66,11 +66,6 @@ There are 3 types of tests which are used for DPC++ toolchain validation:
6666
should not have hardware (e.g. GPU, FPGA, etc.) or external software
6767
dependencies (e.g. OpenCL, Level Zero, CUDA runtimes). All tests not following
6868
this approach should be moved to DPC++ end-to-end or SYCL-CTS tests.
69-
However, the tests for a feature under active development requiring atomic
70-
change for tests and product can be put to
71-
[sycl/test/on-device](../../sycl/test/on-device) temporarily. It is developer
72-
responsibility to move the tests to DPC++ E2E test suite or SYCL-CTS once
73-
the feature is stabilized.
7469

7570
**Guidelines for adding DPC++ in-tree LIT tests (DPC++ Clang FE tests)**:
7671
- Use `sycl::` namespace instead of `cl::sycl::`

sycl/test/CMakeLists.txt

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -105,4 +105,3 @@ if(SYCL_BUILD_PI_ROCM)
105105

106106
add_dependencies(check-sycl check-sycl-rocm)
107107
endif()
108-
add_subdirectory(on-device)

sycl/test/lit.cfg.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@
2727
config.suffixes = ['.c', '.cpp', '.dump'] #add .spv. Currently not clear what to do with those
2828

2929
# feature tests are considered not so lightweight, so, they are excluded by default
30-
config.excludes = ['Inputs', 'feature-tests', 'on-device']
30+
config.excludes = ['Inputs', 'feature-tests']
3131

3232
# test_source_root: The root path where tests are located.
3333
config.test_source_root = os.path.dirname(__file__)

sycl/test/on-device/CMakeLists.txt

Lines changed: 0 additions & 56 deletions
This file was deleted.

sycl/test/on-device/README.md

Lines changed: 0 additions & 70 deletions
This file was deleted.

sycl/test/on-device/back_to_back_collectives.cpp

Lines changed: 0 additions & 73 deletions
This file was deleted.

sycl/test/on-device/basic_tests/aspects.cpp

Lines changed: 0 additions & 106 deletions
This file was deleted.

sycl/test/on-device/basic_tests/diagnostics/device-check.cpp

Lines changed: 0 additions & 51 deletions
This file was deleted.

0 commit comments

Comments
 (0)