Skip to content

Commit 46a55f9

Browse files
author
Oleg Schelykalnov
committed
Fix recursive call to javaToTypeScript.
1 parent e539950 commit 46a55f9

File tree

2 files changed

+21
-3
lines changed

2 files changed

+21
-3
lines changed

typescript-generator-core/src/main/java/cz/habarta/typescript/generator/compiler/ModelCompiler.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -302,7 +302,7 @@ private <T> TsBeanModel processBean(SymbolTable symbolTable, Model model, Map<Ty
302302
TsBeanCategory.Data,
303303
isClass,
304304
symbolTable.getSymbol(bean.getOrigin()),
305-
getTypeParameters(bean.getOrigin()),
305+
getTypeParameters(symbolTable, bean.getOrigin()),
306306
parentType,
307307
extendsList,
308308
implementsList,
@@ -319,13 +319,13 @@ private boolean mappedToClass(Class<?> cls) {
319319
return cls != null && !cls.isInterface() && settings.getMapClassesAsClassesFilter().test(cls.getName());
320320
}
321321

322-
private List<TsType.BoundedGenericVariableType> getTypeParameters(Class<?> cls) {
322+
private List<TsType.BoundedGenericVariableType> getTypeParameters(SymbolTable symbolTable, Class<?> cls) {
323323
final List<TsType.BoundedGenericVariableType> typeParameters = new ArrayList<>();
324324
for (TypeVariable<?> typeParameter : cls.getTypeParameters()) {
325325
final List<TsType> bounds = new ArrayList<>();
326326
for (Type bound : typeParameter.getBounds()) {
327327
if (!Object.class.equals(bound)) {
328-
bounds.add(javaToTypeScript(bound));
328+
bounds.add(typeFromJava(symbolTable, bound));
329329
}
330330
}
331331
switch (bounds.size()) {

typescript-generator-core/src/test/java/cz/habarta/typescript/generator/GenericsTest.java

Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -159,6 +159,19 @@ public void testGenericBoundsParameter() {
159159
assertEquals(expected, output.trim());
160160
}
161161

162+
@Test
163+
public void testGenericRecirsiveBoundsParameter() {
164+
final Settings settings = TestUtils.settings();
165+
final String output = new TypeScriptGenerator(settings).generateTypeScript(Input.from(H.class));
166+
final String nl = settings.newline;
167+
final String expected =
168+
"interface H<T, S extends H<T, S>> {" + nl +
169+
" x: T;" + nl +
170+
" y: S;" + nl +
171+
"}";
172+
assertEquals(expected, output.trim());
173+
}
174+
162175
class A<U,V> {
163176
public A<String, String> x;
164177
public A<A<String, B>, List<String>> y;
@@ -186,6 +199,11 @@ class G<T extends F> {
186199
public T x;
187200
}
188201

202+
class H<T, S extends H<T, S>> {
203+
public T x;
204+
public S y;
205+
}
206+
189207
abstract class IA implements IB<String>, Comparable<IA> {
190208
}
191209

0 commit comments

Comments
 (0)