Correct puppet-strings documentation (#192)

In various places @attr was used instead of @param. It also didn't use
the @summary tag which led to odd summaries. Then some indenting was
incorrect.

It also uses a newer version of puppet-strings which generates a
list of parameters with links.

Author: ekohl

Diff for: REFERENCE.md

@@ -4,40 +4,40 @@
 #
 # @see systemd.unit(5)
 #
-# @attr name [Pattern['^[^/]+\.conf$']]
+# @param name [Pattern['^[^/]+\.conf$']]
 #   The target unit file to create
 #
-# @attr path
+# @param path
 #   The main systemd configuration path
 #
-# @attr selinux_ignore_defaults
+# @param selinux_ignore_defaults
 #   If Puppet should ignore the default SELinux labels.
 #
-# @attr content
+# @param content
 #   The full content of the unit file
 #
 #   * Mutually exclusive with ``$source``
 #
-# @attr source
+# @param source
 #   The ``File`` resource compatible ``source``
 #
 #   * Mutually exclusive with ``$content``
 #
-# @attr target
+# @param target
 #   If set, will force the file to be a symlink to the given target
 #
 #   * Mutually exclusive with both ``$source`` and ``$content``
 #
-# @attr owner
+# @param owner
 #   The owner to set on the dropin file
 #
-# @attr group
+# @param group
 #   The group to set on the dropin file
 #
-# @attr mode
+# @param mode
 #   The mode to set on the dropin file
 #
-# @attr show_diff
+# @param show_diff
 #   Whether to show the diff when updating dropin file
 #
 define systemd::dropin_file (

Diff for: manifests/dropin_file.pp

@@ -1,8 +1,6 @@
 # @api private
-#
-# This class manages and configures journald.
-#
-# https://www.freedesktop.org/software/systemd/man/journald.conf.html
+# @summary This class manages and configures journald.
+# @see https://www.freedesktop.org/software/systemd/man/journald.conf.html
 class systemd::journald {
   assert_private()
 

Diff for: manifests/journald.pp

@@ -1,8 +1,6 @@
 # @api private
-#
-# This class manages systemd's login manager configuration.
-#
-# https://www.freedesktop.org/software/systemd/man/logind.conf.html
+# @summary This class manages systemd's login manager configuration.
+# @see https://www.freedesktop.org/software/systemd/man/logind.conf.html
 class systemd::logind {
   assert_private()
 

Diff for: manifests/logind.pp

@@ -1,5 +1,4 @@
-# -- Define: systemd::network
-# Creates network config for systemd-networkd
+# @summary Creates network config for systemd-networkd
 define systemd::network (
   Enum['file', 'absent']         $ensure          = file,
   Stdlib::Absolutepath           $path            = '/etc/systemd/network',

Diff for: manifests/network.pp

@@ -1,8 +1,8 @@
 # @api private
 #
-# This class provides an abstract way to trigger resolved.
-# Each parameters correspond to resolved.conf(5):
-# https://www.freedesktop.org/software/systemd/man/resolved.conf.html
+# @summary This class provides an abstract way to trigger resolved.
+# Each parameters correspond to resolved.conf(5)
+# @see https://www.freedesktop.org/software/systemd/man/resolved.conf.html
 #
 # @param ensure
 #   The state that the ``resolved`` service should be in

Diff for: manifests/resolved.pp

@@ -4,10 +4,10 @@
 #
 # @see systemd.exec(5)
 #
-# @attr name [Pattern['^.+\.(service|socket|mount|swap)$']]
+# @param name [Pattern['^.+\.(service|socket|mount|swap)$']]
 #   The name of the service that you will be modifying
 #
-# @param $ensure
+# @param ensure
 #   Whether to drop a file or remove it
 #
 # @param path
@@ -24,7 +24,7 @@
 # @param source
 #   A ``File`` resource compatible ``source``
 #
-#  * Mutually exclusive with ``$limits``
+#   * Mutually exclusive with ``$limits``
 #
 # @param restart_service
 #   Restart the managed service after setting the limits

Diff for: manifests/service_limits.pp

@@ -5,7 +5,7 @@
 # @param ensure
 #   The state that the ``networkd`` service should be in
 #
-# @param $ntp_server
+# @param ntp_server
 #   A space-separated list of NTP servers, will be combined with interface specific
 #   addresses from systemd-networkd. requires puppetlabs-inifile
 #

Diff for: manifests/timesyncd.pp

@@ -4,10 +4,10 @@
 #
 # @see systemd-tmpfiles(8)
 #
-# @attr name [Pattern['^[^/]+\.conf$']] (filename)
+# @param name [Pattern['^[^/]+\.conf$']] (filename)
 #   The name of the tmpfile to create
 #
-# @param $ensure
+# @param ensure
 #   Whether to drop a file or remove it
 #
 # @param path
@@ -21,7 +21,7 @@
 # @param source
 #   A ``File`` resource compatible ``source``
 #
-#  * Mutually exclusive with ``$limits``
+#   * Mutually exclusive with ``$limits``
 #
 define systemd::tmpfile (
   Enum['present', 'absent', 'file'] $ensure   = 'file',

Diff for: manifests/tmpfile.pp

@@ -4,10 +4,10 @@
 #
 # @see udev(7)
 #
-# @attr name [Pattern['^.+\.rules$']]
+# @param name [Pattern['^.+\.rules$']]
 #   The name of the udev rules to create
 #
-# @param $ensure
+# @param ensure
 #   Whether to drop a file or remove it
 #
 # @param path

Diff for: manifests/udev/rule.pp

@@ -1,8 +1,6 @@
 # @api private
-#
-# This class manages systemd's udev config
-#
-# https://www.freedesktop.org/software/systemd/man/udev.conf.html
+# @summary This class manages systemd's udev config
+# @see https://www.freedesktop.org/software/systemd/man/udev.conf.html
 class systemd::udevd {
   assert_private()