Allow LimitCORE in [Service] for manage_unit/dropin

Addition of LimitCOR to `[service]` section of
`systemd::manage_unit` and `systemd::manage_dropin`

Added as penance for giving a wrong guess twice to someone how
to do this. Always confuse me since while:

`systemctl show sshd.service -t LimitCORESoft` has a value it cannot be
set as I understand it.

* https://www.freedesktop.org/software/systemd/man/systemd.exec.html#Process%20Properties

Author: traylenator

REFERENCE.md

@@ -794,6 +794,18 @@ systemd::manage_dropin { 'triggerlimit.conf':
 }
 ```
 
+##### drop in file to override the LimitCORE for a service
+
+```puppet
+systemd::manage_dropin { 'corelimit.conf':
+  ensure     => present,
+  unit       => 'rsyslog.conf',
+  path_entry => {
+    'LimitCORE' => 'infinity',
+  },
+}
+```
+
 #### Parameters
 
 The following parameters are available in the `systemd::manage_dropin` defined type:
@@ -2259,6 +2271,7 @@ Struct[{
     Optional['KillSignal']                => Pattern[/^SIG[A-Z]+$/],
     Optional['KillMode']                  => Enum['control-group', 'mixed', 'process', 'none'],
     Optional['SyslogIdentifier']          => String,
+    Optional['LimitCORE']                 => Pattern['^(infinity|((\d+(K|M|G|T|P|E)?(:\d+(K|M|G|T|P|E)?)?)))$'],
     Optional['RestartSec']                => String,
     Optional['TimeoutStartSec']           => String,
     Optional['TimeoutStopSec']            => String,

manifests/manage_dropin.pp

@@ -14,7 +14,7 @@
 #     },
 #   }
 #
-## @example drop in file to change a path unit and override TriggerLimitBurst
+# @example drop in file to change a path unit and override TriggerLimitBurst
 #   systemd::manage_dropin { 'triggerlimit.conf':
 #     ensure     => present,
 #     unit       => 'passwd.path',
@@ -23,6 +23,15 @@
 #     },
 #   }
 #
+# @example drop in file to override the LimitCORE for a service
+#   systemd::manage_dropin { 'corelimit.conf':
+#     ensure     => present,
+#     unit       => 'rsyslog.conf',
+#     path_entry => {
+#       'LimitCORE' => 'infinity',
+#     },
+#   }
+#
 # @param unit The unit to create a dropfile for
 # @param filename The target unit file to create. The filename of the drop in. The full path is determined using the path, unit and this filename.
 # @param ensure The state of this dropin file

spec/defines/manage_dropin_spec.rb

@@ -24,13 +24,15 @@
                   DefaultDependencies: true
                 },
                 service_entry: {
-                  SyslogIdentifier: 'simple'
+                  SyslogIdentifier: 'simple',
+                  LimitCORE: 'infinity',
                 }
               )
             end
 
             it {
               is_expected.to contain_systemd__dropin_file('foobar.conf').
+                with_content(%r{^LimitCORE=infinity$}).
                 with_content(%r{^DefaultDependencies=true$}).
                 with_content(%r{^SyslogIdentifier=simple$})
             }

spec/type_aliases/systemd_unit_service_spec.rb

@@ -27,6 +27,9 @@
   it { is_expected.to allow_value({ 'KillSignal' => 'SIGTERM' }) }
   it { is_expected.not_to allow_value({ 'KillSignal' => 'SIGterm' }) }
   it { is_expected.not_to allow_value({ 'KillSignal' => 9 }) }
+  it { is_expected.to allow_value({ 'LimitCORE' => 'infinity' }) }
+  it { is_expected.to allow_value({ 'LimitCORE' => '100M' }) }
+  it { is_expected.not_to allow_value({ 'LimitCORE' => 'random string' }) }
 
   it { is_expected.to allow_value({ 'ExecStart' => 'notabsolute.sh' }) }
   it { is_expected.not_to allow_value({ 'ExecStart' => '*/wrongprefix.sh' }) }

types/unit/service.pp

@@ -23,6 +23,7 @@
     Optional['KillSignal']                => Pattern[/^SIG[A-Z]+$/],
     Optional['KillMode']                  => Enum['control-group', 'mixed', 'process', 'none'],
     Optional['SyslogIdentifier']          => String,
+    Optional['LimitCORE']                 => Pattern['^(infinity|((\d+(K|M|G|T|P|E)?(:\d+(K|M|G|T|P|E)?)?)))$'],
     Optional['RestartSec']                => String,
     Optional['TimeoutStartSec']           => String,
     Optional['TimeoutStopSec']            => String,