-
Notifications
You must be signed in to change notification settings - Fork 70
Mypy Support? #57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I am interested in taking these here, yes. I am not sure whether I would prefer separate I am not familiar with mypy, though, so I am not used to its best-practices, or maybe there is some tool to convert between annotation types. |
I know https://github.com/ilevkivskyi/com2ann exists for converting py2 comment types to py3 but I am unaware of a tool that does the reverse. For reference, support for comment based types is oulined in https://mypy.readthedocs.io/en/stable/python2.html. I would have to do some research but I am currently unaware of how we would use comment based types for all of the dynamic exports defined in In any case, I'll continue work to finish up the stubs as best I can and we can go from there. |
Maybe it is time to drop Python 2.7 support now (as well as Python 3.5 or older). |
I've got a WIP implementation of mypy type stubs for this package in adbpy/transports@43a26a8.
I haven't finished them yet but I'm opening this issue to get the conversation going. Is this something you would be interested in taking upstream once complete? Otherwise, I'll look into breaking them out into a separate stubs-only package.
The text was updated successfully, but these errors were encountered: