[3.12] pythongh-105866: fix dataclass with slots=True, weakref_slot=True (pythonGH-105870) (pythonGH-116978)

(cherry picked from commit a22d05f)

Co-authored-by: Aviel Boag <[email protected]>
Co-authored-by: Kirill Podoprigora <[email protected]>
Co-authored-by: Carl Meyer <[email protected]>

Author: 4 people

Lib/dataclasses.py

@@ -1168,8 +1168,10 @@ def _dataclass_setstate(self, state):
 
 def _get_slots(cls):
     match cls.__dict__.get('__slots__'):
+        # A class which does not define __slots__ at all is equivalent
+        # to a class defining __slots__ = ('__dict__', '__weakref__')
         case None:
-            return
+            yield from ('__dict__', '__weakref__')
         case str(slot):
             yield slot
         # Slots may be any iterable, but we cannot handle an iterator

Lib/test/test_dataclasses/__init__.py

@@ -3403,6 +3403,17 @@ class A(Base):
         self.assertIs(a.__weakref__, a_ref)
 
 
+    def test_dataclass_derived_weakref_slot(self):
+        class A:
+            pass
+
+        @dataclass(slots=True, weakref_slot=True)
+        class B(A):
+            pass
+
+        B()
+
+
 class TestDescriptors(unittest.TestCase):
     def test_set_name(self):
         # See bpo-33141.

Misc/NEWS.d/next/Library/2023-06-16-19-17-06.gh-issue-105866.0NBveV.rst

@@ -0,0 +1 @@
+Fixed ``_get_slots`` bug which caused error when defining dataclasses with slots and a weakref_slot.