Skip to content

Feature request: Delay until loaded #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
rudolfbyker opened this issue May 5, 2020 · 5 comments
Closed

Feature request: Delay until loaded #22

rudolfbyker opened this issue May 5, 2020 · 5 comments

Comments

@rudolfbyker
Copy link

My app has a loading animation outside of the element in which Vue is mounted:

<body>
  <div id="loading" role="progressbar">
    <img src="<%= BASE_URL %>animation.gif" alt="" />
    <div>Loading…</div>
  </div>
  <div id="app" aria-busy="true"></div>
</body>

One Vue is mounted and everything is loaded, the animation fades out and is removed from the DOM:

<body>
  <div id="app">
    <!--- Vue SPA is mounted here, and provides the <main> tag. --->
  </div>
</body>

I would like to delay running VueAxe until the loading is completed. I.e. I would like to start it manually, or delay it until a certain event fires, because VueAxe is complaining about a few things like missing

tag, etc. while loading.
@ktquez
Copy link
Member

ktquez commented May 7, 2020

Hi @rudolfbyker, how are you?

A great idea, I'll put it on the vue-axe v3 checklist.

Thank you for that.

@rudolfbyker
Copy link
Author

Hi there, and thanks for you consideration.

@ktquez ktquez mentioned this issue May 9, 2020
Merged
9 tasks
@ktquez
Copy link
Member

ktquez commented May 13, 2020 •
edited
Loading

@rudolfbyker

Now available in this v2.
We added the delay and also a way to execute it manually.

Thanks for the suggestion.

@ktquez ktquez closed this as completed May 13, 2020
@rudolfbyker
Copy link
Author

Thanks, it's great that I can now run it manually, but how do I disable the automatic run when I do that?

@ktquez
Copy link
Member

ktquez commented May 13, 2020

@rudolfbyker

I even thought of inserting a skip or auto, but I didn't add it.

At the moment you can, when manually executing, clear the console, through the clearConsole property.

Soon, I will add a property to disable automatic mode.

Thank you for that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ktquez @rudolfbyker