Skip to content

🎈 fix <a-statistic-countdown> slots error #4996

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Dec 8, 2021
Merged

🎈 fix <a-statistic-countdown> slots error #4996

merged 6 commits into from
Dec 8, 2021

Conversation

24min
Copy link
Contributor

@24min 24min commented Dec 7, 2021 •
edited
Loading

Fix <a-statistic-countdown> can't slot Bug

This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Branch merge
  • Other (about what?)

What's the background?

In the documentation on the official website, I found that the countdown component can slot title、suffix and prefix.

But in my practice, this feature doesn't work correctly

In this case, the problem of recurrence [Vue Antd Template (forked) - CodeSandbox].

I tried to fix that, and that's why the PR came in.

Self Check before Merge

  • Doc is updated/provided
  • Demo is updated/provided

tangjinzhou
tangjinzhou requested changes Dec 7, 2021
View reviewed changes
components/statistic/Countdown.tsx Outdated
@@ -84,6 +87,11 @@ export default defineComponent({
valueRender: valueRenderHtml,
formatter: formatCountdown,
}}
v-slots={{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

v-slots={slots} 就可以了吧

components/statistic/Countdown.tsx Outdated
@@ -84,6 +87,11 @@ export default defineComponent({
valueRender: valueRenderHtml,
formatter: formatCountdown,
}}
v-slots={{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

v-slots={slots} 就可以了吧

@tangjinzhou tangjinzhou merged commit ee3188a into vueComponent:next Dec 8, 2021
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tangjinzhou tangjinzhou tangjinzhou requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@24min @tangjinzhou