Skip to content

config/index.js hard-codes localhost as config.dev.host #1128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
b-jazz opened this issue Dec 1, 2017 · 1 comment
Closed

config/index.js hard-codes localhost as config.dev.host #1128

b-jazz opened this issue Dec 1, 2017 · 1 comment

Comments

@b-jazz
Copy link

b-jazz commented Dec 1, 2017

If you override the host from localhost to 192.168.0.2 in your webpack config when starting webpack-dev-server, the script will still output "Your application is running here: http://localhost:8080" instead of "Your application is running here: http://192.168.0.2:8080".

I've fixed this locally by making the following config/index.js diff:

-    host: 'localhost', // can be overwritten by process.env.HOST
+    host: process.env.HOST || 'localhost', // can be overwritten by process.env.HOST

I'd issue a pull request but I'm not sure yet if this has any negative affect on things like tests.

@LinusBorg
Copy link
Contributor

LinusBorg commented Dec 1, 2017

Thanks for reporting this. We already fixed this in the develop branch (#1103)

It will be published shortly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants