Skip to content

Commit 96e5ce3

Browse files
committed
fix: add colon in event name for dynamic model arguments
fixes #602
1 parent 687be8a commit 96e5ce3

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

packages/babel-plugin-jsx/src/transform-vue-jsx.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -194,7 +194,7 @@ const buildProps = (path: NodePath<t.JSXElement>, state: State) => {
194194
}
195195

196196
const updateName = isDynamic
197-
? t.binaryExpression('+', t.stringLiteral('onUpdate'), propName)
197+
? t.binaryExpression('+', t.stringLiteral('onUpdate:'), propName)
198198
: t.stringLiteral(`onUpdate:${(propName as t.StringLiteral)?.value || 'modelValue'}`);
199199

200200
properties.push(

packages/babel-plugin-jsx/test/__snapshots__/snapshot.test.ts.snap

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -273,7 +273,7 @@ const b = {
273273
};
274274
_createVNode(_Fragment, null, [_createVNode(_resolveComponent(\\"A\\"), {
275275
[foo]: xx,
276-
[\\"onUpdate\\" + foo]: $event => xx = $event
276+
[\\"onUpdate:\\" + foo]: $event => xx = $event
277277
}, null, 16), _createVNode(_resolveComponent(\\"B\\"), {
278278
\\"modelValue\\": xx,
279279
\\"modelModifiers\\": {
@@ -285,25 +285,25 @@ _createVNode(_Fragment, null, [_createVNode(_resolveComponent(\\"A\\"), {
285285
[foo + \\"Modifiers\\"]: {
286286
\\"a\\": true
287287
},
288-
[\\"onUpdate\\" + foo]: $event => xx = $event
288+
[\\"onUpdate:\\" + foo]: $event => xx = $event
289289
}, null, 16), _createVNode(_resolveComponent(\\"D\\"), {
290290
[foo === 'foo' ? 'a' : 'b']: xx,
291291
[(foo === 'foo' ? 'a' : 'b') + \\"Modifiers\\"]: {
292292
\\"a\\": true
293293
},
294-
[\\"onUpdate\\" + (foo === 'foo' ? 'a' : 'b')]: $event => xx = $event
294+
[\\"onUpdate:\\" + (foo === 'foo' ? 'a' : 'b')]: $event => xx = $event
295295
}, null, 16), _createVNode(_resolveComponent(\\"E\\"), {
296296
[a()]: xx,
297297
[a() + \\"Modifiers\\"]: {
298298
\\"a\\": true
299299
},
300-
[\\"onUpdate\\" + a()]: $event => xx = $event
300+
[\\"onUpdate:\\" + a()]: $event => xx = $event
301301
}, null, 16), _createVNode(_resolveComponent(\\"F\\"), {
302302
[b.c]: xx,
303303
[b.c + \\"Modifiers\\"]: {
304304
\\"a\\": true
305305
},
306-
[\\"onUpdate\\" + b.c]: $event => xx = $event
306+
[\\"onUpdate:\\" + b.c]: $event => xx = $event
307307
}, null, 16)]);"
308308
`;
309309

0 commit comments

Comments
 (0)