Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Defining unknown properties as exist properties is wrong #609

Closed
yoyo930021 opened this issue Dec 7, 2020 · 2 comments · Fixed by #610
Closed

Defining unknown properties as exist properties is wrong #609

yoyo930021 opened this issue Dec 7, 2020 · 2 comments · Fixed by #610
Labels
typing

Comments

@yoyo930021
Copy link
Member

From vuejs/vetur#2505

The @vue/composition-api define unknown properties as exist properties.

Wrong:
https://user-images.githubusercontent.com/15092120/100864081-cb44fe80-3495-11eb-8fa2-abd0a9e049ea.png

Wanted:
https://user-images.githubusercontent.com/15092120/101005269-16781380-3561-11eb-8ab7-f54982776e84.png
@yoyo930021 yoyo930021 changed the title unknown properties infer define any Define unknown properties as exist properties. Dec 7, 2020
@yoyo930021 yoyo930021 changed the title Define unknown properties as exist properties. Defining unknown properties as exist properties is wrong Dec 7, 2020
@yoyo930021 yoyo930021 changed the title Defining unknown properties as exist properties is wrong Defining unknown properties as existence properties is wrong Dec 7, 2020
@yoyo930021 yoyo930021 changed the title Defining unknown properties as existence properties is wrong Defining unknown properties as exist properties is wrong Dec 7, 2020
@pikax pikax added the needs reproduction We need a runnable reproduction from the OP label Dec 7, 2020
@pikax
Copy link
Member

pikax commented Dec 7, 2020

Can you provide a reproduction, from the issue mention it seems it's been using @nuxtjs/composition-api and nuxt-property-decorator.

If you can provide an reproduction of using @vue/composition-api it would be great

@yoyo930021
Copy link
Member Author

yoyo930021 commented Dec 7, 2020 •
edited
Loading

Can you provide a reproduction, from the issue mention it seems it's been using @nuxtjs/composition-api and nuxt-property-decorator.

If you can provide an reproduction of using @vue/composition-api it would be great

Repro case:
https://github.com/yoyo930021/vue2-composition-api-unknown-property

Dec-07-2020 18-30-44

@pikax pikax added typing and removed needs reproduction We need a runnable reproduction from the OP labels Dec 7, 2020
@pikax pikax mentioned this issue Dec 7, 2020
Merged
@antfu antfu closed this as completed in #610 Dec 7, 2020
@nagaraja0yellapu nagaraja0yellapu mentioned this issue Jul 29, 2022
Closed
@CRMaxime CRMaxime mentioned this issue Aug 12, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
typing
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

types(defineComponent): fix options API support when using defineComponent pikax/vue-function-api
2 participants
@pikax @yoyo930021