Skip to content

watch breaks for ref with shallowReadonly #712

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
schTi opened this issue May 27, 2021 · 1 comment · Fixed by #714
Closed

watch breaks for ref with shallowReadonly #712

schTi opened this issue May 27, 2021 · 1 comment · Fixed by #714

Comments

@schTi
Copy link

schTi commented May 27, 2021

Version: v1.0.0-rc.10

After aligning the watch behavior in the latest release, my watchers are broken for ref variables, that have a shallowReadonly around them. This is because isRef does not return true for these kind of variables and so the getter will throw an error, that it got an invalid watch source.

Any chance to get this fixed?
@hyf0
Copy link
Contributor

hyf0 commented May 28, 2021 •
edited
Loading

@schTi Could you provide an online example? That would be very helpful.

@ygj6 ygj6 mentioned this issue May 29, 2021
Merged
@antfu antfu closed this as completed in #714 Jun 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(shallowReadonly): watch should work for ref/reactive with shallowReadonly ygj6/composition-api
2 participants
@schTi @hyf0