Skip to content

Commit 228b8d6

Browse files
committed
fix(suspense): give pending suspense vnode placeholder el
close #10017
1 parent 972face commit 228b8d6

File tree

2 files changed

+3
-2
lines changed

2 files changed

+3
-2
lines changed

packages/runtime-core/__tests__/components/Suspense.spec.ts

+2-2
Original file line numberDiff line numberDiff line change
@@ -1692,7 +1692,7 @@ describe('Suspense', () => {
16921692
expect(serializeInner(root)).toBe(`<div>sync</div>`)
16931693
})
16941694

1695-
// #6416 follow up
1695+
// #6416 follow up / #10017
16961696
test('Suspense patched during HOC async component re-mount', async () => {
16971697
const key = ref('k')
16981698
const data = ref('data')
@@ -1713,7 +1713,7 @@ describe('Suspense', () => {
17131713
const App = {
17141714
render() {
17151715
return h(Suspense, null, {
1716-
default: h(Comp, { data: data.value }),
1716+
default: h(Comp, { k: key.value, data: data.value }),
17171717
})
17181718
},
17191719
}

packages/runtime-core/src/renderer.ts

+1
Original file line numberDiff line numberDiff line change
@@ -1245,6 +1245,7 @@ function baseCreateRenderer(
12451245
if (!initialVNode.el) {
12461246
const placeholder = (instance.subTree = createVNode(Comment))
12471247
processCommentNode(null, placeholder, container!, anchor)
1248+
initialVNode.el = placeholder.el
12481249
}
12491250
} else {
12501251
setupRenderEffect(

0 commit comments

Comments
 (0)