Skip to content

Commit 6bc0415

Browse files
committed
refactor: replace const enum with enum
1 parent 021a47a commit 6bc0415

32 files changed

+62
-153
lines changed

Diff for: packages/compiler-core/src/ast.ts

+4-4
Original file line numberDiff line numberDiff line change
@@ -21,11 +21,11 @@ import { ImportItem, TransformContext } from './transform'
2121
// compilers.
2222
export type Namespace = number
2323

24-
export const enum Namespaces {
24+
export enum Namespaces {
2525
HTML
2626
}
2727

28-
export const enum NodeTypes {
28+
export enum NodeTypes {
2929
ROOT,
3030
ELEMENT,
3131
TEXT,
@@ -59,7 +59,7 @@ export const enum NodeTypes {
5959
JS_RETURN_STATEMENT
6060
}
6161

62-
export const enum ElementTypes {
62+
export enum ElementTypes {
6363
ELEMENT,
6464
COMPONENT,
6565
SLOT,
@@ -202,7 +202,7 @@ export interface DirectiveNode extends Node {
202202
* Higher levels implies lower levels. e.g. a node that can be stringified
203203
* can always be hoisted and skipped for patch.
204204
*/
205-
export const enum ConstantTypes {
205+
export enum ConstantTypes {
206206
NOT_CONSTANT = 0,
207207
CAN_SKIP_PATCH,
208208
CAN_HOIST,

Diff for: packages/compiler-core/src/compat/compatConfig.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ export interface CompilerCompatOptions {
1313
compatConfig?: CompilerCompatConfig
1414
}
1515

16-
export const enum CompilerDeprecationTypes {
16+
export enum CompilerDeprecationTypes {
1717
COMPILER_IS_ON_ELEMENT = 'COMPILER_IS_ON_ELEMENT',
1818
COMPILER_V_BIND_SYNC = 'COMPILER_V_BIND_SYNC',
1919
COMPILER_V_BIND_PROP = 'COMPILER_V_BIND_PROP',

Diff for: packages/compiler-core/src/errors.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ export function createCompilerError<T extends number>(
3737
return error
3838
}
3939

40-
export const enum ErrorCodes {
40+
export enum ErrorCodes {
4141
// parse errors
4242
ABRUPT_CLOSING_OF_EMPTY_COMMENT,
4343
CDATA_IN_HTML_CONTENT,

Diff for: packages/compiler-core/src/options.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,7 @@ export type HoistTransform = (
7373
parent: ParentNode
7474
) => void
7575

76-
export const enum BindingTypes {
76+
export enum BindingTypes {
7777
/**
7878
* returned from data()
7979
*/

Diff for: packages/compiler-core/src/parse.ts

+2-2
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,7 @@ export const defaultParserOptions: MergedParserOptions = {
8080
comments: __DEV__
8181
}
8282

83-
export const enum TextModes {
83+
export enum TextModes {
8484
// | Elements | Entities | End sign | Inside of
8585
DATA, // | ✔ | ✔ | End tags of ancestors |
8686
RCDATA, // | ✘ | ✔ | End tag of the parent | <textarea>
@@ -502,7 +502,7 @@ function parseElement(
502502
return element
503503
}
504504

505-
const enum TagType {
505+
enum TagType {
506506
Start,
507507
End
508508
}

Diff for: packages/compiler-core/src/utils.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@ const nonIdentifierRE = /^\d|[^\$\w]/
6464
export const isSimpleIdentifier = (name: string): boolean =>
6565
!nonIdentifierRE.test(name)
6666

67-
const enum MemberExpLexState {
67+
enum MemberExpLexState {
6868
inMemberExp,
6969
inBrackets,
7070
inParens,

Diff for: packages/compiler-dom/src/errors.ts

+2-2
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ export function createDOMCompilerError(
2020
) as DOMCompilerError
2121
}
2222

23-
export const enum DOMErrorCodes {
23+
export enum DOMErrorCodes {
2424
X_V_HTML_NO_EXPRESSION = 53 /* ErrorCodes.__EXTEND_POINT__ */,
2525
X_V_HTML_WITH_CHILDREN,
2626
X_V_TEXT_NO_EXPRESSION,
@@ -36,7 +36,7 @@ export const enum DOMErrorCodes {
3636
}
3737

3838
if (__TEST__) {
39-
// esbuild cannot infer const enum increments if first value is from another
39+
// esbuild cannot infer enum increments if first value is from another
4040
// file, so we have to manually keep them in sync. this check ensures it
4141
// errors out if there are collisions.
4242
if (DOMErrorCodes.X_V_HTML_NO_EXPRESSION < ErrorCodes.__EXTEND_POINT__) {

Diff for: packages/compiler-dom/src/parserOptions.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ const isRawTextContainer = /*#__PURE__*/ makeMap(
1515
true
1616
)
1717

18-
export const enum DOMNamespaces {
18+
export enum DOMNamespaces {
1919
HTML = 0 /* Namespaces.HTML */,
2020
SVG,
2121
MATH_ML

Diff for: packages/compiler-dom/src/transforms/stringifyStatic.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ import {
3333
} from '@vue/shared'
3434
import { DOMNamespaces } from '../parserOptions'
3535

36-
export const enum StringifyThresholds {
36+
export enum StringifyThresholds {
3737
ELEMENT_WITH_BINDING_COUNT = 5,
3838
NODE_COUNT = 20
3939
}

Diff for: packages/compiler-sfc/src/style/cssVars.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,7 @@ export function parseCssVars(sfc: SFCDescriptor): string[] {
7070
return vars
7171
}
7272

73-
const enum LexerState {
73+
enum LexerState {
7474
inParens,
7575
inSingleQuoteString,
7676
inDoubleQuoteString

Diff for: packages/compiler-ssr/src/errors.ts

+2-2
Original file line numberDiff line numberDiff line change
@@ -16,14 +16,14 @@ export function createSSRCompilerError(
1616
return createCompilerError(code, loc, SSRErrorMessages) as SSRCompilerError
1717
}
1818

19-
export const enum SSRErrorCodes {
19+
export enum SSRErrorCodes {
2020
X_SSR_UNSAFE_ATTR_NAME = 65 /* DOMErrorCodes.__EXTEND_POINT__ */,
2121
X_SSR_NO_TELEPORT_TARGET,
2222
X_SSR_INVALID_AST_NODE
2323
}
2424

2525
if (__TEST__) {
26-
// esbuild cannot infer const enum increments if first value is from another
26+
// esbuild cannot infer enum increments if first value is from another
2727
// file, so we have to manually keep them in sync. this check ensures it
2828
// errors out if there are collisions.
2929
if (SSRErrorCodes.X_SSR_UNSAFE_ATTR_NAME < DOMErrorCodes.__EXTEND_POINT__) {

Diff for: packages/reactivity/src/index.ts

+2-5
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ export {
3131
shallowReadonly,
3232
markRaw,
3333
toRaw,
34-
ReactiveFlags /* @remove */,
34+
ReactiveFlags,
3535
type Raw,
3636
type DeepReadonly,
3737
type ShallowReactive,
@@ -69,7 +69,4 @@ export {
6969
getCurrentScope,
7070
onScopeDispose
7171
} from './effectScope'
72-
export {
73-
TrackOpTypes /* @remove */,
74-
TriggerOpTypes /* @remove */
75-
} from './operations'
72+
export { TrackOpTypes, TriggerOpTypes } from './operations'

Diff for: packages/reactivity/src/operations.ts

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,13 @@
11
// using literal strings instead of numbers so that it's easier to inspect
22
// debugger events
33

4-
export const enum TrackOpTypes {
4+
export enum TrackOpTypes {
55
GET = 'get',
66
HAS = 'has',
77
ITERATE = 'iterate'
88
}
99

10-
export const enum TriggerOpTypes {
10+
export enum TriggerOpTypes {
1111
SET = 'set',
1212
ADD = 'add',
1313
DELETE = 'delete',

Diff for: packages/reactivity/src/reactive.ts

+2-2
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ import {
1313
} from './collectionHandlers'
1414
import type { UnwrapRefSimple, Ref, RawSymbol } from './ref'
1515

16-
export const enum ReactiveFlags {
16+
export enum ReactiveFlags {
1717
SKIP = '__v_skip',
1818
IS_REACTIVE = '__v_isReactive',
1919
IS_READONLY = '__v_isReadonly',
@@ -34,7 +34,7 @@ export const shallowReactiveMap = new WeakMap<Target, any>()
3434
export const readonlyMap = new WeakMap<Target, any>()
3535
export const shallowReadonlyMap = new WeakMap<Target, any>()
3636

37-
const enum TargetType {
37+
enum TargetType {
3838
INVALID = 0,
3939
COMMON = 1,
4040
COLLECTION = 2

Diff for: packages/runtime-core/src/compat/compatConfig.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ import {
1010
} from '../component'
1111
import { warn } from '../warning'
1212

13-
export const enum DeprecationTypes {
13+
export enum DeprecationTypes {
1414
GLOBAL_MOUNT = 'GLOBAL_MOUNT',
1515
GLOBAL_MOUNT_CONTAINER = 'GLOBAL_MOUNT_CONTAINER',
1616
GLOBAL_EXTEND = 'GLOBAL_EXTEND',

Diff for: packages/runtime-core/src/componentOptions.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -586,7 +586,7 @@ export type OptionTypesType<
586586
Defaults: Defaults
587587
}
588588

589-
const enum OptionTypes {
589+
enum OptionTypes {
590590
PROPS = 'Props',
591591
DATA = 'Data',
592592
COMPUTED = 'Computed',

Diff for: packages/runtime-core/src/componentProps.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -164,7 +164,7 @@ export type ExtractPublicPropTypes<O> = {
164164
[K in keyof Pick<O, PublicOptionalKeys<O>>]?: InferPropType<O[K]>
165165
}
166166

167-
const enum BooleanFlags {
167+
enum BooleanFlags {
168168
shouldCast,
169169
shouldCastTrue
170170
}

Diff for: packages/runtime-core/src/componentPublicInstance.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -278,7 +278,7 @@ if (__COMPAT__) {
278278
installCompatInstanceProperties(publicPropertiesMap)
279279
}
280280

281-
const enum AccessTypes {
281+
enum AccessTypes {
282282
OTHER,
283283
SETUP,
284284
DATA,

Diff for: packages/runtime-core/src/components/Teleport.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -269,7 +269,7 @@ export const TeleportImpl = {
269269
hydrate: hydrateTeleport
270270
}
271271

272-
export const enum TeleportMoveTypes {
272+
export enum TeleportMoveTypes {
273273
TARGET_CHANGE,
274274
TOGGLE, // enable / disable
275275
REORDER // moved in the main view

Diff for: packages/runtime-core/src/devtools.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ interface AppRecord {
1010
types: Record<string, string | Symbol>
1111
}
1212

13-
const enum DevtoolsHooks {
13+
enum DevtoolsHooks {
1414
APP_INIT = 'app:init',
1515
APP_UNMOUNT = 'app:unmount',
1616
COMPONENT_UPDATED = 'component:updated',

Diff for: packages/runtime-core/src/enums.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
export const enum LifecycleHooks {
1+
export enum LifecycleHooks {
22
BEFORE_CREATE = 'bc',
33
CREATED = 'c',
44
BEFORE_MOUNT = 'bm',

Diff for: packages/runtime-core/src/errorHandling.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ import { LifecycleHooks } from './enums'
66

77
// contexts where user provided function may be executed, in addition to
88
// lifecycle hooks.
9-
export const enum ErrorCodes {
9+
export enum ErrorCodes {
1010
SETUP_FUNCTION,
1111
RENDER_FUNCTION,
1212
WATCH_GETTER,

Diff for: packages/runtime-core/src/hydration.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ export type RootHydrateFunction = (
3030
container: (Element | ShadowRoot) & { _vnode?: VNode }
3131
) => void
3232

33-
const enum DOMNodeTypes {
33+
enum DOMNodeTypes {
3434
ELEMENT = 1,
3535
TEXT = 3,
3636
COMMENT = 8

Diff for: packages/runtime-core/src/renderer.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -264,7 +264,7 @@ export type SetupRenderEffectFn = (
264264
optimized: boolean
265265
) => void
266266

267-
export const enum MoveType {
267+
export enum MoveType {
268268
ENTER,
269269
LEAVE,
270270
REORDER

Diff for: packages/runtime-test/src/nodeOps.ts

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,12 @@
11
import { markRaw } from '@vue/reactivity'
22

3-
export const enum TestNodeTypes {
3+
export enum TestNodeTypes {
44
TEXT = 'text',
55
ELEMENT = 'element',
66
COMMENT = 'comment'
77
}
88

9-
export const enum NodeOpTypes {
9+
export enum NodeOpTypes {
1010
CREATE = 'create',
1111
INSERT = 'insert',
1212
REMOVE = 'remove',

Diff for: packages/shared/src/patchFlags.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616
* Check the `patchElement` function in '../../runtime-core/src/renderer.ts' to see how the
1717
* flags are handled during diff.
1818
*/
19-
export const enum PatchFlags {
19+
export enum PatchFlags {
2020
/**
2121
* Indicates an element with dynamic textContent (children fast path)
2222
*/

Diff for: packages/shared/src/shapeFlags.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
export const enum ShapeFlags {
1+
export enum ShapeFlags {
22
ELEMENT = 1,
33
FUNCTIONAL_COMPONENT = 1 << 1,
44
STATEFUL_COMPONENT = 1 << 2,

Diff for: packages/shared/src/slotFlags.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
export const enum SlotFlags {
1+
export enum SlotFlags {
22
/**
33
* Stable slots that only reference slot props or context state. The slot
44
* can fully capture its own dependencies so when passed down the parent won't

Diff for: packages/vue/macros.d.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ import {
1010

1111
export declare const RefType: unique symbol
1212

13-
export declare const enum RefTypes {
13+
export declare enum RefTypes {
1414
Ref = 1,
1515
ComputedRef = 2,
1616
WritableComputedRef = 3

Diff for: rollup.config.js

+2-3
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ import terser from '@rollup/plugin-terser'
1212
import esbuild from 'rollup-plugin-esbuild'
1313
import alias from '@rollup/plugin-alias'
1414
import { entries } from './scripts/aliases.js'
15-
import { constEnum } from './scripts/const-enum.js'
15+
import { enums } from './scripts/enum.js'
1616

1717
if (!process.env.TARGET) {
1818
throw new Error('TARGET package must be specified via --environment flag.')
@@ -32,7 +32,7 @@ const pkg = require(resolve(`package.json`))
3232
const packageOptions = pkg.buildOptions || {}
3333
const name = packageOptions.filename || path.basename(packageDir)
3434

35-
const [enumPlugin, enumDefines] = constEnum()
35+
const enumDefines = enums()
3636

3737
const outputConfigs = {
3838
'esm-bundler': {
@@ -285,7 +285,6 @@ function createConfig(format, output, plugins = []) {
285285
alias({
286286
entries
287287
}),
288-
enumPlugin,
289288
...resolveReplace(),
290289
esbuild({
291290
tsconfig: path.resolve(__dirname, 'tsconfig.json'),

Diff for: scripts/build.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ nr build core --formats cjs
1717
*/
1818

1919
import fs from 'node:fs/promises'
20-
import { existsSync, readFileSync } from 'node:fs'
20+
import { existsSync } from 'node:fs'
2121
import path from 'node:path'
2222
import minimist from 'minimist'
2323
import { gzipSync, brotliCompressSync } from 'node:zlib'
@@ -26,7 +26,7 @@ import execa from 'execa'
2626
import { cpus } from 'node:os'
2727
import { createRequire } from 'node:module'
2828
import { targets as allTargets, fuzzyMatchTarget } from './utils.js'
29-
import { scanEnums } from './const-enum.js'
29+
import { scanEnums } from './enum.js'
3030
import prettyBytes from 'pretty-bytes'
3131

3232
const require = createRequire(import.meta.url)

0 commit comments

Comments
 (0)