refactor: remove unnecessary check as filter is always non-null (#11599)

edison1105 · web-flow · commit 73fa91fabd43 · 2024-08-13T22:05:14.000+08:00
diff --git a/packages/runtime-core/src/components/KeepAlive.ts b/packages/runtime-core/src/components/KeepAlive.ts
@@ -195,10 +195,10 @@ const KeepAliveImpl: ComponentOptions = {
       _unmount(vnode, instance, parentSuspense, true)
     }
 
-    function pruneCache(filter?: (name: string) => boolean) {
+    function pruneCache(filter: (name: string) => boolean) {
       cache.forEach((vnode, key) => {
         const name = getComponentName(vnode.type as ConcreteComponent)
-        if (name && (!filter || !filter(name))) {
+        if (name && !filter(name)) {
           pruneCacheEntry(key)
         }
       })

Original file line number	Diff line number	Diff line change
`@@ -195,10 +195,10 @@ const KeepAliveImpl: ComponentOptions = {`
`195`	`195`	`_unmount(vnode, instance, parentSuspense, true)`
`196`	`196`	`}`
`197`	`197`
`198`		`- function pruneCache(filter?: (name: string) => boolean) {`
	`198`	`+ function pruneCache(filter: (name: string) => boolean) {`
`199`	`199`	`cache.forEach((vnode, key) => {`
`200`	`200`	`const name = getComponentName(vnode.type as ConcreteComponent)`
`201`		`- if (name && (!filter \|\| !filter(name))) {`
	`201`	`+ if (name && !filter(name)) {`
`202`	`202`	`pruneCacheEntry(key)`
`203`	`203`	`}`
`204`	`204`	`})`