chore: enforce the use of top-level import type

Author: Alfred-Skyblue

.eslintrc.cjs

@@ -41,6 +41,8 @@ module.exports = {
         fixStyle: 'inline-type-imports',
       },
     ],
+    // Enforce the use of top-level import type qualifier when an import only has specifiers with inline type qualifiers
+    '@typescript-eslint/no-import-type-side-effects': 'error',
   },
   overrides: [
     // tests, no restrictions (runs in Node / jest with jsdom)

packages/compiler-core/__tests__/parse.spec.ts

@@ -1,4 +1,4 @@
-import { type ParserOptions } from '../src/options'
+import type { ParserOptions } from '../src/options'
 import { baseParse, TextModes } from '../src/parse'
 import { ErrorCodes } from '../src/errors'
 import {

packages/compiler-core/__tests__/transforms/vModel.spec.ts

@@ -19,7 +19,7 @@ import { transformElement } from '../../src/transforms/transformElement'
 import { transformExpression } from '../../src/transforms/transformExpression'
 import { transformFor } from '../../src/transforms/vFor'
 import { trackSlotScopes } from '../../src/transforms/vSlot'
-import { type CallExpression } from '@babel/types'
+import type { CallExpression } from '@babel/types'
 
 function parseWithVModel(template: string, options: CompilerOptions = {}) {
   const ast = parse(template)

packages/compiler-core/__tests__/utils.spec.ts

@@ -1,5 +1,5 @@
-import { type TransformContext } from '../src'
-import { type Position } from '../src/ast'
+import type { TransformContext } from '../src'
+import type { Position } from '../src/ast'
 import {
   getInnerRange,
   advancePositionWithClone,

packages/compiler-core/src/ast.ts

@@ -1,5 +1,5 @@
 import { isString } from '@vue/shared'
-import { type ForParseResult } from './transforms/vFor'
+import type { ForParseResult } from './transforms/vFor'
 import {
   type RENDER_SLOT,
   type CREATE_SLOTS,
@@ -13,8 +13,8 @@ import {
   CREATE_BLOCK,
   CREATE_ELEMENT_BLOCK,
 } from './runtimeHelpers'
-import { type PropsExpression } from './transforms/transformElement'
-import { type ImportItem, type TransformContext } from './transform'
+import type { PropsExpression } from './transforms/transformElement'
+import type { ImportItem, TransformContext } from './transform'
 
 // Vue template is a platform-agnostic superset of HTML (syntax only).
 // More namespaces like SVG and MathML are declared by platform specific

packages/compiler-core/src/codegen.ts

@@ -1,4 +1,4 @@
-import { type CodegenOptions } from './options'
+import type { CodegenOptions } from './options'
 import {
   type RootNode,
   type TemplateChildNode,
@@ -54,7 +54,7 @@ import {
   WITH_CTX,
   RESOLVE_FILTER,
 } from './runtimeHelpers'
-import { type ImportItem } from './transform'
+import type { ImportItem } from './transform'
 
 const PURE_ANNOTATION = `/*#__PURE__*/`
 

packages/compiler-core/src/compat/compatConfig.ts

@@ -1,7 +1,7 @@
-import { type SourceLocation } from '../ast'
-import { type CompilerError } from '../errors'
-import { type ParserContext } from '../parse'
-import { type TransformContext } from '../transform'
+import type { SourceLocation } from '../ast'
+import type { CompilerError } from '../errors'
+import type { ParserContext } from '../parse'
+import type { TransformContext } from '../transform'
 
 export type CompilerCompatConfig = Partial<
   Record<CompilerDeprecationTypes, boolean | 'suppress-warning'>

packages/compiler-core/src/compat/transformFilter.ts

@@ -11,7 +11,7 @@ import {
   isCompatEnabled,
   warnDeprecation,
 } from './compatConfig'
-import { type NodeTransform, type TransformContext } from '../transform'
+import type { NodeTransform, TransformContext } from '../transform'
 import { toValidAssetId } from '../utils'
 
 const validDivisionCharRE = /[\w).+\-_$\]]/

packages/compiler-core/src/compile.ts

@@ -1,12 +1,12 @@
-import { type CompilerOptions } from './options'
+import type { CompilerOptions } from './options'
 import { baseParse } from './parse'
 import {
   transform,
   type NodeTransform,
   type DirectiveTransform,
 } from './transform'
 import { generate, type CodegenResult } from './codegen'
-import { type RootNode } from './ast'
+import type { RootNode } from './ast'
 import { isString, extend } from '@vue/shared'
 import { transformIf } from './transforms/vIf'
 import { transformFor } from './transforms/vFor'

packages/compiler-core/src/errors.ts

@@ -1,4 +1,4 @@
-import { type SourceLocation } from './ast'
+import type { SourceLocation } from './ast'
 
 export interface CompilerError extends SyntaxError {
   code: number | string

packages/compiler-core/src/options.ts

@@ -1,18 +1,18 @@
-import {
-  type ElementNode,
-  type Namespace,
-  type TemplateChildNode,
-  type ParentNode,
+import type {
+  ElementNode,
+  Namespace,
+  TemplateChildNode,
+  ParentNode,
 } from './ast'
-import { type TextModes } from './parse'
-import { type CompilerError } from './errors'
-import {
-  type NodeTransform,
-  type DirectiveTransform,
-  type TransformContext,
+import type { TextModes } from './parse'
+import type { CompilerError } from './errors'
+import type {
+  NodeTransform,
+  DirectiveTransform,
+  TransformContext,
 } from './transform'
-import { type CompilerCompatOptions } from './compat/compatConfig'
-import { type ParserPlugin } from '@babel/parser'
+import type { CompilerCompatOptions } from './compat/compatConfig'
+import type { ParserPlugin } from '@babel/parser'
 
 export interface ErrorHandlingOptions {
   onWarn?: (warning: CompilerError) => void

packages/compiler-core/src/parse.ts

@@ -1,4 +1,4 @@
-import { type ErrorHandlingOptions, type ParserOptions } from './options'
+import type { ErrorHandlingOptions, ParserOptions } from './options'
 import { NO, isArray, makeMap, extend } from '@vue/shared'
 import {
   ErrorCodes,

packages/compiler-core/src/transform.ts

@@ -1,4 +1,4 @@
-import { type TransformOptions } from './options'
+import type { TransformOptions } from './options'
 import {
   type RootNode,
   NodeTypes,
@@ -39,7 +39,7 @@ import {
 } from './runtimeHelpers'
 import { isVSlot } from './utils'
 import { hoistStatic, isSingleElementRoot } from './transforms/hoistStatic'
-import { type CompilerCompatOptions } from './compat/compatConfig'
+import type { CompilerCompatOptions } from './compat/compatConfig'
 
 // There are two types of transforms:
 //

packages/compiler-core/src/transforms/hoistStatic.ts

@@ -16,7 +16,7 @@ import {
   getVNodeBlockHelper,
   getVNodeHelper,
 } from '../ast'
-import { type TransformContext } from '../transform'
+import type { TransformContext } from '../transform'
 import { PatchFlags, isString, isSymbol, isArray } from '@vue/shared'
 import { isSlotOutlet } from '../utils'
 import {

packages/compiler-core/src/transforms/noopDirectiveTransform.ts

@@ -1,3 +1,3 @@
-import { type DirectiveTransform } from '../transform'
+import type { DirectiveTransform } from '../transform'
 
 export const noopDirectiveTransform: DirectiveTransform = () => ({ props: [] })

packages/compiler-core/src/transforms/transformElement.ts

@@ -1,4 +1,4 @@
-import { type NodeTransform, type TransformContext } from '../transform'
+import type { NodeTransform, TransformContext } from '../transform'
 import {
   NodeTypes,
   ElementTypes,

packages/compiler-core/src/transforms/transformExpression.ts

@@ -7,7 +7,7 @@
 // - This transform is only applied in non-browser builds because it relies on
 //   an additional JavaScript parser. In the browser, there is no source-map
 //   support and the code is wrapped in `with (this) { ... }`.
-import { type NodeTransform, type TransformContext } from '../transform'
+import type { NodeTransform, TransformContext } from '../transform'
 import {
   NodeTypes,
   createSimpleExpression,
@@ -32,7 +32,7 @@ import {
   genPropsAccessExp,
 } from '@vue/shared'
 import { createCompilerError, ErrorCodes } from '../errors'
-import { type Node, type Identifier } from '@babel/types'
+import type { Node, Identifier } from '@babel/types'
 import { validateBrowserExpression } from '../validateExpression'
 import { parse } from '@babel/parser'
 import { IS_REF, UNREF } from '../runtimeHelpers'

packages/compiler-core/src/transforms/transformSlotOutlet.ts

@@ -1,4 +1,4 @@
-import { type NodeTransform, type TransformContext } from '../transform'
+import type { NodeTransform, TransformContext } from '../transform'
 import {
   NodeTypes,
   type CallExpression,

packages/compiler-core/src/transforms/transformText.ts

@@ -1,4 +1,4 @@
-import { type NodeTransform } from '../transform'
+import type { NodeTransform } from '../transform'
 import {
   NodeTypes,
   type CompoundExpressionNode,

packages/compiler-core/src/transforms/vBind.ts

@@ -1,4 +1,4 @@
-import { type DirectiveTransform } from '../transform'
+import type { DirectiveTransform } from '../transform'
 import {
   createObjectProperty,
   createSimpleExpression,

packages/compiler-core/src/transforms/vMemo.ts

@@ -1,4 +1,4 @@
-import { type NodeTransform } from '../transform'
+import type { NodeTransform } from '../transform'
 import { findDir } from '../utils'
 import {
   convertToBlock,

packages/compiler-core/src/transforms/vModel.ts

@@ -1,4 +1,4 @@
-import { type DirectiveTransform } from '../transform'
+import type { DirectiveTransform } from '../transform'
 import {
   createSimpleExpression,
   createObjectProperty,

packages/compiler-core/src/transforms/vOn.ts

@@ -1,7 +1,4 @@
-import {
-  type DirectiveTransform,
-  type DirectiveTransformResult,
-} from '../transform'
+import type { DirectiveTransform, DirectiveTransformResult } from '../transform'
 import {
   createCompoundExpression,
   createObjectProperty,

packages/compiler-core/src/transforms/vOnce.ts

@@ -1,4 +1,4 @@
-import { type NodeTransform } from '../transform'
+import type { NodeTransform } from '../transform'
 import { findDir } from '../utils'
 import { type ElementNode, type ForNode, type IfNode, NodeTypes } from '../ast'
 import { SET_BLOCK_TRACKING } from '../runtimeHelpers'

packages/compiler-core/src/transforms/vSlot.ts

@@ -21,7 +21,7 @@ import {
   createArrayExpression,
   type SlotsExpression,
 } from '../ast'
-import { type TransformContext, type NodeTransform } from '../transform'
+import type { TransformContext, NodeTransform } from '../transform'
 import { createCompilerError, ErrorCodes } from '../errors'
 import {
   findDir,

packages/compiler-core/src/utils.ts

@@ -25,7 +25,7 @@ import {
   type BlockCodegenNode,
   type MemoExpression,
 } from './ast'
-import { type TransformContext } from './transform'
+import type { TransformContext } from './transform'
 import {
   MERGE_PROPS,
   TELEPORT,
@@ -38,9 +38,9 @@ import {
   WITH_MEMO,
 } from './runtimeHelpers'
 import { isString, isObject, hyphenate, extend, NOOP } from '@vue/shared'
-import { type PropsExpression } from './transforms/transformElement'
+import type { PropsExpression } from './transforms/transformElement'
 import { parseExpression } from '@babel/parser'
-import { type Expression } from '@babel/types'
+import type { Expression } from '@babel/types'
 
 export const isStaticExp = (p: JSChildNode): p is SimpleExpressionNode =>
   p.type === NodeTypes.SIMPLE_EXPRESSION && p.isStatic

packages/compiler-core/src/validateExpression.ts

@@ -1,5 +1,5 @@
-import { type SimpleExpressionNode } from './ast'
-import { type TransformContext } from './transform'
+import type { SimpleExpressionNode } from './ast'
+import type { TransformContext } from './transform'
 import { createCompilerError, ErrorCodes } from './errors'
 
 // these keywords should not appear inside expressions, but operators like

packages/compiler-dom/src/decodeHtml.ts

@@ -1,4 +1,4 @@
-import { type ParserOptions } from '@vue/compiler-core'
+import type { ParserOptions } from '@vue/compiler-core'
 import namedCharacterReferences from './namedChars.json'
 
 // lazy compute this to make this file tree-shakable for browser

packages/compiler-dom/src/transforms/vShow.ts

@@ -1,4 +1,4 @@
-import { type DirectiveTransform } from '@vue/compiler-core'
+import type { DirectiveTransform } from '@vue/compiler-core'
 import { createDOMCompilerError, DOMErrorCodes } from '../errors'
 import { V_SHOW } from '../runtimeHelpers'
 

packages/compiler-sfc/__tests__/compileScript/definePropsDestructure.spec.ts

@@ -1,5 +1,5 @@
 import { BindingTypes } from '@vue/compiler-core'
-import { type SFCScriptCompileOptions } from '../../src'
+import type { SFCScriptCompileOptions } from '../../src'
 import { compileSFCScript, assertCode } from '../utils'
 
 describe('sfc reactive props destructure', () => {

packages/compiler-sfc/__tests__/compileScript/hoistStatic.spec.ts

@@ -1,5 +1,5 @@
 import { BindingTypes } from '@vue/compiler-core'
-import { type SFCScriptCompileOptions } from '../../src'
+import type { SFCScriptCompileOptions } from '../../src'
 import { compileSFCScript, assertCode } from '../utils'
 
 describe('sfc hoist static', () => {

packages/compiler-sfc/__tests__/compileScript/resolveType.spec.ts

@@ -1,4 +1,4 @@
-import { type Identifier } from '@babel/types'
+import type { Identifier } from '@babel/types'
 import { type SFCScriptCompileOptions, parse } from '../../src'
 import { ScriptCompileContext } from '../../src/script/context'
 import {

packages/compiler-sfc/src/compileScript.ts

@@ -9,20 +9,20 @@ import {
   type SFCDescriptor,
   type SFCScriptBlock,
 } from './parse'
-import { type ParserPlugin } from '@babel/parser'
+import type { ParserPlugin } from '@babel/parser'
 import { generateCodeFrame } from '@vue/shared'
-import {
-  type Node,
-  type Declaration,
-  type ObjectPattern,
-  type ArrayPattern,
-  type Identifier,
-  type ExportSpecifier,
-  type Statement,
-  type CallExpression,
+import type {
+  Node,
+  Declaration,
+  ObjectPattern,
+  ArrayPattern,
+  Identifier,
+  ExportSpecifier,
+  Statement,
+  CallExpression,
 } from '@babel/types'
 import { walk } from 'estree-walker'
-import { type RawSourceMap } from 'source-map-js'
+import type { RawSourceMap } from 'source-map-js'
 import {
   processNormalScript,
   normalScriptDefaultVar,

packages/compiler-sfc/src/compileStyle.ts

@@ -13,7 +13,7 @@ import {
   type StylePreprocessorResults,
   type PreprocessLang,
 } from './style/preprocessors'
-import { type RawSourceMap } from 'source-map-js'
+import type { RawSourceMap } from 'source-map-js'
 import { cssVarsPlugin } from './style/cssVars'
 import postcssModules from 'postcss-modules'
 

packages/compiler-sfc/src/compileTemplate.ts

@@ -1,10 +1,10 @@
-import {
-  type CompilerOptions,
-  type CodegenResult,
-  type CompilerError,
-  type NodeTransform,
-  type ParserOptions,
-  type RootNode,
+import type {
+  CompilerOptions,
+  CodegenResult,
+  CompilerError,
+  NodeTransform,
+  ParserOptions,
+  RootNode,
 } from '@vue/compiler-core'
 import {
   SourceMapConsumer,

packages/compiler-sfc/src/parse.ts

@@ -8,12 +8,12 @@ import {
 } from '@vue/compiler-core'
 import * as CompilerDOM from '@vue/compiler-dom'
 import { type RawSourceMap, SourceMapGenerator } from 'source-map-js'
-import { type TemplateCompiler } from './compileTemplate'
+import type { TemplateCompiler } from './compileTemplate'
 import { parseCssVars } from './style/cssVars'
 import { createCache } from './cache'
-import { type ImportBinding } from './compileScript'
+import type { ImportBinding } from './compileScript'
 import { isImportUsed } from './script/importUsageCheck'
-import { type Statement } from '@babel/types'
+import type { Statement } from '@babel/types'
 
 export const DEFAULT_FILENAME = 'anonymous.vue'