refactor: should throw errors in computed getters

yyx990803 · yyx990803 · commit 85f3592725e1 · 2024-04-24T17:27:51.000+08:00
diff --git a/packages/reactivity/src/effect.ts b/packages/reactivity/src/effect.ts
@@ -375,12 +375,13 @@ export function refreshComputed(computed: ComputedRefImpl) {
     }
   } catch (err) {
     dep.version++
+    throw err
+  } finally {
+    activeSub = prevSub
+    shouldTrack = prevShouldTrack
+    cleanupDeps(computed)
+    computed.flags &= ~EffectFlags.RUNNING
   }
-
-  activeSub = prevSub
-  shouldTrack = prevShouldTrack
-  cleanupDeps(computed)
-  computed.flags &= ~EffectFlags.RUNNING
 }
 
 function removeSub(link: Link) {

Original file line number	Diff line number	Diff line change
`@@ -375,12 +375,13 @@ export function refreshComputed(computed: ComputedRefImpl) {`
`375`	`375`	`}`
`376`	`376`	`} catch (err) {`
`377`	`377`	`dep.version++`
	`378`	`+ throw err`
	`379`	`+ } finally {`
	`380`	`+ activeSub = prevSub`
	`381`	`+ shouldTrack = prevShouldTrack`
	`382`	`+ cleanupDeps(computed)`
	`383`	`+ computed.flags &= ~EffectFlags.RUNNING`
`378`	`384`	`}`
`379`		`-`
`380`		`- activeSub = prevSub`
`381`		`- shouldTrack = prevShouldTrack`
`382`		`- cleanupDeps(computed)`
`383`		`- computed.flags &= ~EffectFlags.RUNNING`
`384`	`385`	`}`
`385`	`386`
`386`	`387`	`function removeSub(link: Link) {`