Skip to content

Commit 627f490

Browse files
committed
fix: revert the --tests flag behavior
Fixes #297 To avoid confusions, the `--tests` flag should include exact *one* set of test configurations. In the previous versions, it was Vitest for unit testing and Cypress for E2E testing. So for consistency, we remove the newly added Nightwatch template from it. But as we have more and more testing options, I would encourage everyone to specify the name of the testing framework they want to use, rather than use the general `--tests` flag. It would also be less prone to bugs
1 parent 3675eae commit 627f490

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

Diff for: index.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -296,7 +296,7 @@ async function init() {
296296
const { needsE2eTesting } = result
297297
const needsCypress = argv.cypress || argv.tests || needsE2eTesting === 'cypress'
298298
const needsCypressCT = needsCypress && !needsVitest
299-
const needsNightwatch = argv.nightwatch || argv.tests || needsE2eTesting === 'nightwatch'
299+
const needsNightwatch = argv.nightwatch || needsE2eTesting === 'nightwatch'
300300
const needsNightwatchCT = needsNightwatch && !needsVitest
301301
const needsPlaywright = argv.playwright || needsE2eTesting === 'playwright'
302302

0 commit comments

Comments
 (0)