Skip to content

rename tsconfig.config.json to tsconfig.node.json #231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
tjx666 opened this issue Feb 23, 2023 · 3 comments
Closed

rename tsconfig.config.json to tsconfig.node.json #231

tjx666 opened this issue Feb 23, 2023 · 3 comments

Comments

@tjx666
Copy link
Contributor

tjx666 commented Feb 23, 2023

image

like vue-ts template:

image

@tjx666
Copy link
Contributor Author

tjx666 commented Feb 23, 2023

@sodatea If you feel it ok, I would like to make a pr

@haoqunjiang
Copy link
Member

Yeah, PR is welcome!

I initially named it tsconfig.config.json because I thought we might need to add some types to it (e.g., vitest if we want to configure it inside a test field in vite.config.ts), but it's never used so far.
So yeah, tsconfig.node.json may be more useful, and it's good to keep consistency with Vite templates.

@tjx666
Copy link
Contributor Author

tjx666 commented Feb 24, 2023

@sodatea pr review needed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants