fix: avoid exception when opening devtools on a non-vue page (#1663)

javier-garcia-meteologica · web-flow · commit 10629e15666e · 2022-01-12T15:20:18.000+01:00
diff --git a/packages/shell-chrome/src/devtools-background.js b/packages/shell-chrome/src/devtools-background.js
@@ -16,7 +16,7 @@ function createPanelIfHasVue () {
     return
   }
   chrome.devtools.inspectedWindow.eval(
-    '!!(window.__VUE_DEVTOOLS_GLOBAL_HOOK__.Vue || window.__VUE_DEVTOOLS_GLOBAL_HOOK__.apps.length)',
+    '!!(window.__VUE_DEVTOOLS_GLOBAL_HOOK__ && (window.__VUE_DEVTOOLS_GLOBAL_HOOK__.Vue || window.__VUE_DEVTOOLS_GLOBAL_HOOK__.apps.length))',
     function (hasVue) {
       if (!hasVue || created) {
         return

Original file line number	Diff line number	Diff line change
`@@ -16,7 +16,7 @@ function createPanelIfHasVue () {`
`16`	`16`	`return`
`17`	`17`	`}`
`18`	`18`	`chrome.devtools.inspectedWindow.eval(`
`19`		`- '!!(window.__VUE_DEVTOOLS_GLOBAL_HOOK__.Vue \|\| window.__VUE_DEVTOOLS_GLOBAL_HOOK__.apps.length)',`
	`19`	`+ '!!(window.__VUE_DEVTOOLS_GLOBAL_HOOK__ && (window.__VUE_DEVTOOLS_GLOBAL_HOOK__.Vue \|\| window.__VUE_DEVTOOLS_GLOBAL_HOOK__.apps.length))',`
`20`	`20`	`function (hasVue) {`
`21`	`21`	`if (!hasVue \|\| created) {`
`22`	`22`	`return`