-
Notifications
You must be signed in to change notification settings - Fork 4.7k
Search page #352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
@NoelDeMartin it would be great to have the same page for new docs! Regarding 'where to implement' question: I believe it would be beneficial for VuePress as well but if you think it would be faster/easier to add it to docs website only - let's implement it here first. You also reminded me that I need to apply for Algolia DocSearch token 😅 |
@NoelDeMartin VuePress comes with a built-in search functionality, so I wonder if it makes sense to see if there's a way you can leverage it to build the search page (rather than starting from scratch). That said, if VuePress search functionality could use some improvement, then I think we could use your help on updating the VuePress library itself so a lot more people can benefit from your ideas! |
Hi @bencodezen. I've been looking into the @vuepress/plugin-search plugin and I'll probably make a PR to add it there afterwards. But the docs at the moment are built using VuePress If I create a PR here first, it's more likely that it gets merged before the official release of v3 :). |
Uh oh!
There was an error while loading. Please reload this page.
In v2 there was a separate search page at
/search
in order to have a url to run searches. For example: https://vuejs.org/v2/search/?q=v%2DmodelI implemented that in this PR, so you can take a look there for the motivations and discussion.
Would it make sense to do the same here? Would it make more sense to implement this feature in VuePress instead?
The text was updated successfully, but these errors were encountered: