Skip to content

Update computed properties example #289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jul 20, 2020
Merged

Conversation

NataliaTepluhina
Copy link
Member

Changed an example of computed properties to be less cryptic and more 'real-life'

Close #38

@NataliaTepluhina NataliaTepluhina added the enhancement New feature or request label Jul 20, 2020
Copy link
Member

@bencodezen bencodezen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@NataliaTepluhina This is great! Love the result.

Just had a few suggestions for consistency amongst the book titles, but otherwise you're good to go!

@CyberAP
Copy link
Contributor

CyberAP commented Jul 20, 2020

Would it be reasonable to add an Add book functionality to highlight that computed properties are in fact reactive? That could potentially help to understand why book list was put in data rather than in a variable outside app.

@NataliaTepluhina NataliaTepluhina merged commit c8e036a into master Jul 20, 2020
@NataliaTepluhina NataliaTepluhina deleted the change-computed-examples branch August 3, 2020 04:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor computed properties chapter
3 participants