Skip to content

Commit f3c609d

Browse files
mysticateamichalsnik
authored andcommitted
Fix: unintentional disabling (#331)
1 parent 41e7eee commit f3c609d

File tree

2 files changed

+19
-2
lines changed

2 files changed

+19
-2
lines changed

Diff for: lib/rules/comment-directive.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,8 @@
88
// Helpers
99
// -----------------------------------------------------------------------------
1010

11-
const COMMENT_DIRECTIVE_B = /^\s*(eslint-(?:en|dis)able)\s*(?:(\S|\S[\s\S]*\S)\s*)?$/
12-
const COMMENT_DIRECTIVE_L = /^\s*(eslint-disable(?:-next)?-line)\s*(?:(\S|\S[\s\S]*\S)\s*)?$/
11+
const COMMENT_DIRECTIVE_B = /^\s*(eslint-(?:en|dis)able)(?:\s+(\S|\S[\s\S]*\S))?\s*$/
12+
const COMMENT_DIRECTIVE_L = /^\s*(eslint-disable(?:-next)?-line)(?:\s+(\S|\S[\s\S]*\S))?\s*$/
1313

1414
/**
1515
* Parse a given comment.

Diff for: tests/lib/rules/comment-directive.js

+17
Original file line numberDiff line numberDiff line change
@@ -191,5 +191,22 @@ describe('comment-directive', () => {
191191
assert.deepEqual(messages[0].ruleId, 'vue/no-parsing-error')
192192
assert.deepEqual(messages[1].ruleId, 'vue/no-duplicate-attributes')
193193
})
194+
195+
it('should affect only the next line', () => {
196+
const code = `
197+
<template>
198+
<!-- eslint-disable-next-line vue/no-parsing-error, vue/no-duplicate-attributes -->
199+
<div id id="a">Hello</div>
200+
<div id id="b">Hello</div>
201+
</template>
202+
`
203+
const messages = linter.executeOnText(code, 'test.vue').results[0].messages
204+
205+
assert.deepEqual(messages.length, 2)
206+
assert.deepEqual(messages[0].ruleId, 'vue/no-parsing-error')
207+
assert.deepEqual(messages[0].line, 5)
208+
assert.deepEqual(messages[1].ruleId, 'vue/no-duplicate-attributes')
209+
assert.deepEqual(messages[1].line, 5)
210+
})
194211
})
195212
})

0 commit comments

Comments
 (0)