Skip to content

Commit fa1675c

Browse files
authored
Fix false positive for filename in vue/multi-word-component-names rule (#1689)
1 parent c6ca602 commit fa1675c

File tree

2 files changed

+6
-1
lines changed

2 files changed

+6
-1
lines changed

lib/rules/multi-word-component-names.js

+2-1
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@
88
// Requirements
99
// ------------------------------------------------------------------------------
1010

11+
const path = require('path')
1112
const casing = require('../utils/casing')
1213
const utils = require('../utils')
1314

@@ -111,7 +112,7 @@ module.exports = {
111112
if (hasName) return
112113
if (!hasVue && node.body.length > 0) return
113114
const fileName = context.getFilename()
114-
const componentName = fileName.replace(/\.[^/.]+$/, '')
115+
const componentName = path.basename(fileName, path.extname(fileName))
115116
if (
116117
utils.isVueFile(fileName) &&
117118
!isValidComponentName(componentName)

tests/lib/rules/multi-word-component-names.js

+4
Original file line numberDiff line numberDiff line change
@@ -39,6 +39,10 @@ tester.run('multi-word-component-names', rule, {
3939
filename: 'app.vue',
4040
code: ''
4141
},
42+
{
43+
filename: 'path/to/app.vue',
44+
code: '<script></script>'
45+
},
4246
{
4347
filename: 'invalid.vue',
4448
code: `

0 commit comments

Comments
 (0)