Skip to content

Add Vue.extend as valid component rule trigger #319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
blake-newman opened this issue Jan 2, 2018 · 2 comments
Closed

Add Vue.extend as valid component rule trigger #319

blake-newman opened this issue Jan 2, 2018 · 2 comments
Assignees
@michalsnik
Labels
accepted proposition enhancement

Comments

@blake-newman
Copy link
Member

All component-related rules are being applied to code that passes any of the following checks:

  • Vue.component() expression
  • export default {} in .vue or .jsx file

Suggestion

Add Vue.extend to the triggers for for applying the component related rules. It is a commonly used api fo creating components in a raw formats without SFC.
@michalsnik
Copy link
Member

Good idea @blake-newman On it :)

@michalsnik michalsnik self-assigned this Jan 2, 2018
@michalsnik michalsnik mentioned this issue Jan 2, 2018
Merged
@blake-newman
Copy link
Member Author

Nice, cheers. Was doing it myself you beat me to it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@michalsnik michalsnik

Labels
accepted proposition enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@michalsnik @blake-newman