Skip to content

html-no-self-closing shouldn't be part of the recommended config #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Mouvedia opened this issue Jun 24, 2017 · 3 comments
Closed

html-no-self-closing shouldn't be part of the recommended config #48

Mouvedia opened this issue Jun 24, 2017 · 3 comments

Comments

@Mouvedia
Copy link

What did you expect to happen?

html-no-self-closing should not have been included. I don't see why it should be the default. It's a preference. People used to XHTML won't like that.

What actually happened?

html-no-self-closing was enabled when using plugin:vue/recommended.

@mysticatea
Copy link
Member

Thank you for this issue.

I agree.

That rule has been created in an invalid assumption: HTML does not support self-closing elements, so Vue.js as well. I have learned that Vue.js supports self-closing elements in #29.

Currently, I think that we should remove html-no-self-closing rule entirely then create new html-self-closing rule which people can configure always/never to use self-closing elements. Of course, plugin:vue/recommended should not include the new stylistic rule.

@johnmerced-ks
Copy link

I noticed this as well a couple days ago - Looking forward for this change!

@michalsnik
Copy link
Member

ATM I'll just disable this rule in default configuration, as otherwise we'd need to update major version which is better to be ommited in this beta period. Let's come to a point where we have a stable ground, and then we can remove unnecessary rules and activate new ones in default configuration at once with official v4, that is coming our way. cc @mysticatea

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants