From 4dbe8922057896b72ee0b94171127f63c7c0fe86 Mon Sep 17 00:00:00 2001
From: ota <y.ohta.z3@future.co.jp>
Date: Mon, 7 Jan 2019 16:09:23 +0900
Subject: [PATCH 1/3] =?UTF-8?q?=E2=AD=90=EF=B8=8FNew:=20Add=20`vue/no-rest?=
 =?UTF-8?q?ricted-syntax`=20rule?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Close #689
---
 docs/rules/README.md                    |   1 +
 docs/rules/no-restricted-syntax.md      |  82 +++++++++++++
 lib/index.js                            |   1 +
 lib/rules/no-restricted-syntax.js       |   9 ++
 tests/lib/rules/no-restricted-syntax.js | 152 ++++++++++++++++++++++++
 5 files changed, 245 insertions(+)
 create mode 100644 docs/rules/no-restricted-syntax.md
 create mode 100644 lib/rules/no-restricted-syntax.js
 create mode 100644 tests/lib/rules/no-restricted-syntax.js

diff --git a/docs/rules/README.md b/docs/rules/README.md
index 103e94196..b37c250a0 100644
--- a/docs/rules/README.md
+++ b/docs/rules/README.md
@@ -144,6 +144,7 @@ For example:
 | [vue/eqeqeq](./eqeqeq.md) | require the use of `===` and `!==` | :wrench: |
 | [vue/key-spacing](./key-spacing.md) | enforce consistent spacing between keys and values in object literal properties | :wrench: |
 | [vue/match-component-file-name](./match-component-file-name.md) | require component name property to match its file name |  |
+| [vue/no-restricted-syntax](./no-restricted-syntax.md) | disallow specified syntax |  |
 | [vue/object-curly-spacing](./object-curly-spacing.md) | enforce consistent spacing inside braces | :wrench: |
 | [vue/require-direct-export](./require-direct-export.md) | require the component to be directly exported |  |
 | [vue/script-indent](./script-indent.md) | enforce consistent indentation in `<script>` | :wrench: |
diff --git a/docs/rules/no-restricted-syntax.md b/docs/rules/no-restricted-syntax.md
new file mode 100644
index 000000000..4fc793fd2
--- /dev/null
+++ b/docs/rules/no-restricted-syntax.md
@@ -0,0 +1,82 @@
+---
+pageClass: rule-details
+sidebarDepth: 0
+title: vue/no-restricted-syntax
+description: disallow specified syntax
+---
+# vue/no-restricted-syntax
+> disallow specified syntax
+
+This rule is the same rule as core [no-restricted-syntax] rule but it applies to the expressions in `<template>`.
+
+
+## :wrench: Options
+
+Please see [no-restricted-syntax] for detailed options.
+
+You can include the AST created by `vue-eslint-parser` in the selector.
+To know more about certain nodes in produced AST, please go the [vue-eslint-parser AST docs](https://github.com/mysticatea/vue-eslint-parser/blob/master/docs/ast.md).
+
+### `"VAttribute[directive=true][key.name='on'] > VExpressionContainer > FunctionExpression"`
+
+Forbind function expressions on `v-on`
+
+<eslint-code-block :rules="{'vue/no-restricted-syntax': ['error', 'VAttribute[directive=true][key.name=\'on\'] > VExpressionContainer > FunctionExpression']}">
+
+```vue
+<template>
+  <!-- ✔ GOOD -->
+  <button
+    @click="() => onClick()">
+    GOOD
+  </button>
+  <button
+    @click="onClick()">
+    GOOD
+  </button>
+  <button
+    @click="onClick">
+    GOOD
+  </button>
+
+  <!-- ✘ BAD -->
+  <button
+    @click="function() { onClick() }">
+    BAD
+  </button>
+</template>
+```
+
+</eslint-code-block>
+
+### `"VElement > VExpressionContainer CallExpression"`
+
+Forbind call expressions on mustache interpolation
+
+<eslint-code-block :rules="{'vue/no-restricted-syntax': ['error', 'VElement > VExpressionContainer CallExpression']}">
+
+```vue
+<template>
+  <!-- ✔ GOOD -->
+  <div> {{ foo }} </div>
+  <div> {{ foo.bar }} </div>
+
+  <!-- ✘ BAD -->
+  <div> {{ foo() }} </div>
+  <div> {{ foo.bar() }} </div>
+  <div> {{ foo().bar }} </div>
+</template>
+```
+
+</eslint-code-block>
+
+## :books: Further reading
+
+- [no-restricted-syntax]
+
+[no-restricted-syntax]: https://eslint.org/docs/rules/no-restricted-syntax
+
+## :mag: Implementation
+
+- [Rule source](https://github.com/vuejs/eslint-plugin-vue/blob/master/lib/rules/no-restricted-syntax.js)
+- [Test source](https://github.com/vuejs/eslint-plugin-vue/blob/master/tests/lib/rules/no-restricted-syntax.js)
diff --git a/lib/index.js b/lib/index.js
index df9a21b3c..bb5b86031 100644
--- a/lib/index.js
+++ b/lib/index.js
@@ -33,6 +33,7 @@ module.exports = {
     'no-multi-spaces': require('./rules/no-multi-spaces'),
     'no-parsing-error': require('./rules/no-parsing-error'),
     'no-reserved-keys': require('./rules/no-reserved-keys'),
+    'no-restricted-syntax': require('./rules/no-restricted-syntax'),
     'no-shared-component-data': require('./rules/no-shared-component-data'),
     'no-side-effects-in-computed-properties': require('./rules/no-side-effects-in-computed-properties'),
     'no-spaces-around-equal-signs-in-attribute': require('./rules/no-spaces-around-equal-signs-in-attribute'),
diff --git a/lib/rules/no-restricted-syntax.js b/lib/rules/no-restricted-syntax.js
new file mode 100644
index 000000000..869540001
--- /dev/null
+++ b/lib/rules/no-restricted-syntax.js
@@ -0,0 +1,9 @@
+/**
+ * @author Yosuke Ota
+ */
+'use strict'
+
+const { wrapCoreRule } = require('../utils')
+
+// eslint-disable-next-line
+module.exports = wrapCoreRule(require('eslint/lib/rules/no-restricted-syntax'))
diff --git a/tests/lib/rules/no-restricted-syntax.js b/tests/lib/rules/no-restricted-syntax.js
new file mode 100644
index 000000000..de8448b63
--- /dev/null
+++ b/tests/lib/rules/no-restricted-syntax.js
@@ -0,0 +1,152 @@
+/**
+ * @author Yosuke Ota
+ */
+'use strict'
+
+const RuleTester = require('eslint').RuleTester
+const rule = require('../../../lib/rules/no-restricted-syntax')
+
+const tester = new RuleTester({
+  parser: 'vue-eslint-parser',
+  parserOptions: { ecmaVersion: 2015 }
+})
+
+tester.run('no-restricted-syntax', rule, {
+  valid: [
+    {
+      code: `
+        <template>
+          <button @click="() => onClick()">
+            BUTTON
+          </button>
+        </template>`,
+      options: [
+        {
+          'selector': 'FunctionExpression',
+          'message': 'Function expressions are not allowed.'
+        }
+      ]
+    }
+  ],
+  invalid: [
+    {
+      code: `
+        <template>
+          <button @click="function() { onClick() }">
+            BUTTON
+          </button>
+        </template>`,
+      options: [
+        {
+          'selector': 'FunctionExpression',
+          'message': 'Function expressions are not allowed.'
+        }
+      ],
+      errors: [
+        {
+          message: 'Function expressions are not allowed.',
+          line: 3,
+          column: 27,
+          endLine: 3,
+          endColumn: 51
+        }
+      ]
+    },
+
+    // Forbind function expressions on `v-on`
+    {
+      code: `
+        <template>
+          <button
+            :click="function() { onClick() }"
+            @click="function() { onClick() }"
+            @keydown="() => {
+              (function() { onClick() })()
+            }">
+            BUTTON
+          </button>
+        </template>`,
+      options: [
+        {
+          'selector': "VAttribute[directive=true][key.name='on'] > VExpressionContainer > FunctionExpression",
+          'message': 'Function expressions are not allowed on `v-on`.'
+        }
+      ],
+      errors: [
+        {
+          message: 'Function expressions are not allowed on `v-on`.',
+          line: 5,
+          column: 21,
+          endLine: 5,
+          endColumn: 45
+        }
+      ]
+    },
+
+    // Forbind call expressions on mustache interpolation
+    {
+      code: `
+        <template>
+          <div> {{ foo() }} </div>
+          <div> {{ foo.bar() }} </div>
+          <div> {{ foo().bar }} </div>
+        </template>`,
+      options: [
+        {
+          'selector': 'VElement > VExpressionContainer CallExpression',
+          'message': 'Call expressions are not allowed on mustache interpolation.'
+        }
+      ],
+      errors: [
+        {
+          message: 'Call expressions are not allowed on mustache interpolation.',
+          line: 3,
+          column: 20,
+          endLine: 3,
+          endColumn: 25
+        },
+        {
+          message: 'Call expressions are not allowed on mustache interpolation.',
+          line: 4,
+          column: 20,
+          endLine: 4,
+          endColumn: 29
+        },
+        {
+          message: 'Call expressions are not allowed on mustache interpolation.',
+          line: 5,
+          column: 20,
+          endLine: 5,
+          endColumn: 25
+        }
+      ]
+    },
+
+    // Sample written on issue 689
+    {
+      code: `
+      <template>
+        <div :foo="$gettext(\`bar\`)">{{$gettext(\`bar\`)}}</div>
+      </template>`,
+      options: [
+        "CallExpression[callee.type='Identifier'][callee.name='$gettext'] TemplateLiteral"
+      ],
+      errors: [
+        {
+          message: 'Using \'CallExpression[callee.type=\'Identifier\'][callee.name=\'$gettext\'] TemplateLiteral\' is not allowed.',
+          line: 3,
+          column: 29,
+          endLine: 3,
+          endColumn: 34
+        },
+        {
+          message: 'Using \'CallExpression[callee.type=\'Identifier\'][callee.name=\'$gettext\'] TemplateLiteral\' is not allowed.',
+          line: 3,
+          column: 48,
+          endLine: 3,
+          endColumn: 53
+        }
+      ]
+    }
+  ]
+})

From bee33c64abaeb1f0c3672382c913ce968b304302 Mon Sep 17 00:00:00 2001
From: ota <y.ohta.z3@future.co.jp>
Date: Tue, 8 Jan 2019 15:44:37 +0900
Subject: [PATCH 2/3] =?UTF-8?q?=E2=AD=90=EF=B8=8FNew:=20Add=20`vue/no-rest?=
 =?UTF-8?q?ricted-syntax`=20rule?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Close #689
---
 docs/rules/no-restricted-syntax.md      | 43 ++++----------------
 tests/lib/rules/no-restricted-syntax.js | 54 +++++--------------------
 2 files changed, 18 insertions(+), 79 deletions(-)

diff --git a/docs/rules/no-restricted-syntax.md b/docs/rules/no-restricted-syntax.md
index 4fc793fd2..3ad0db765 100644
--- a/docs/rules/no-restricted-syntax.md
+++ b/docs/rules/no-restricted-syntax.md
@@ -14,44 +14,12 @@ This rule is the same rule as core [no-restricted-syntax] rule but it applies to
 
 Please see [no-restricted-syntax] for detailed options.
 
-You can include the AST created by `vue-eslint-parser` in the selector.
-To know more about certain nodes in produced AST, please go the [vue-eslint-parser AST docs](https://github.com/mysticatea/vue-eslint-parser/blob/master/docs/ast.md).
-
-### `"VAttribute[directive=true][key.name='on'] > VExpressionContainer > FunctionExpression"`
-
-Forbind function expressions on `v-on`
-
-<eslint-code-block :rules="{'vue/no-restricted-syntax': ['error', 'VAttribute[directive=true][key.name=\'on\'] > VExpressionContainer > FunctionExpression']}">
-
-```vue
-<template>
-  <!-- ✔ GOOD -->
-  <button
-    @click="() => onClick()">
-    GOOD
-  </button>
-  <button
-    @click="onClick()">
-    GOOD
-  </button>
-  <button
-    @click="onClick">
-    GOOD
-  </button>
-
-  <!-- ✘ BAD -->
-  <button
-    @click="function() { onClick() }">
-    BAD
-  </button>
-</template>
-```
-
-</eslint-code-block>
+You can include the AST created by [vue-eslint-parser] in the selector.
+To know more about certain nodes in produced AST, please go [vue-eslint-parser - AST docs].
 
 ### `"VElement > VExpressionContainer CallExpression"`
 
-Forbind call expressions on mustache interpolation
+Forbind call expressions on mustache interpolation.
 
 <eslint-code-block :rules="{'vue/no-restricted-syntax': ['error', 'VElement > VExpressionContainer CallExpression']}">
 
@@ -73,8 +41,13 @@ Forbind call expressions on mustache interpolation
 ## :books: Further reading
 
 - [no-restricted-syntax]
+- [ESTree]
+- [vue-eslint-parser]
 
 [no-restricted-syntax]: https://eslint.org/docs/rules/no-restricted-syntax
+[ESTree]: https://github.com/estree/estree
+[vue-eslint-parser]: https://github.com/mysticatea/vue-eslint-parser
+[vue-eslint-parser - AST docs]: https://github.com/mysticatea/vue-eslint-parser/blob/master/docs/ast.md
 
 ## :mag: Implementation
 
diff --git a/tests/lib/rules/no-restricted-syntax.js b/tests/lib/rules/no-restricted-syntax.js
index de8448b63..3a5868e09 100644
--- a/tests/lib/rules/no-restricted-syntax.js
+++ b/tests/lib/rules/no-restricted-syntax.js
@@ -16,14 +16,12 @@ tester.run('no-restricted-syntax', rule, {
     {
       code: `
         <template>
-          <button @click="() => onClick()">
-            BUTTON
-          </button>
+          <input :value="value">
         </template>`,
       options: [
         {
-          'selector': 'FunctionExpression',
-          'message': 'Function expressions are not allowed.'
+          'selector': 'CallExpression',
+          'message': 'Call expressions are not allowed.'
         }
       ]
     }
@@ -32,53 +30,21 @@ tester.run('no-restricted-syntax', rule, {
     {
       code: `
         <template>
-          <button @click="function() { onClick() }">
-            BUTTON
-          </button>
+          <input :value="value()">
         </template>`,
       options: [
         {
-          'selector': 'FunctionExpression',
-          'message': 'Function expressions are not allowed.'
+          'selector': 'CallExpression',
+          'message': 'Call expressions are not allowed.'
         }
       ],
       errors: [
         {
-          message: 'Function expressions are not allowed.',
+          message: 'Call expressions are not allowed.',
           line: 3,
-          column: 27,
+          column: 26,
           endLine: 3,
-          endColumn: 51
-        }
-      ]
-    },
-
-    // Forbind function expressions on `v-on`
-    {
-      code: `
-        <template>
-          <button
-            :click="function() { onClick() }"
-            @click="function() { onClick() }"
-            @keydown="() => {
-              (function() { onClick() })()
-            }">
-            BUTTON
-          </button>
-        </template>`,
-      options: [
-        {
-          'selector': "VAttribute[directive=true][key.name='on'] > VExpressionContainer > FunctionExpression",
-          'message': 'Function expressions are not allowed on `v-on`.'
-        }
-      ],
-      errors: [
-        {
-          message: 'Function expressions are not allowed on `v-on`.',
-          line: 5,
-          column: 21,
-          endLine: 5,
-          endColumn: 45
+          endColumn: 33
         }
       ]
     },
@@ -122,7 +88,7 @@ tester.run('no-restricted-syntax', rule, {
       ]
     },
 
-    // Sample written on issue 689
+    // Sample source code on issue 689
     {
       code: `
       <template>

From 91802eac066e3e60feb28611f7ab888bdb593d3b Mon Sep 17 00:00:00 2001
From: ota <y.ohta.z3@future.co.jp>
Date: Wed, 9 Jan 2019 20:05:38 +0900
Subject: [PATCH 3/3] fixed

---
 docs/rules/no-restricted-syntax.md      |  2 +-
 tests/lib/rules/no-restricted-syntax.js | 10 +++++-----
 2 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/docs/rules/no-restricted-syntax.md b/docs/rules/no-restricted-syntax.md
index 3ad0db765..254439e16 100644
--- a/docs/rules/no-restricted-syntax.md
+++ b/docs/rules/no-restricted-syntax.md
@@ -19,7 +19,7 @@ To know more about certain nodes in produced AST, please go [vue-eslint-parser -
 
 ### `"VElement > VExpressionContainer CallExpression"`
 
-Forbind call expressions on mustache interpolation.
+Forbids call expressions inside mustache interpolation.
 
 <eslint-code-block :rules="{'vue/no-restricted-syntax': ['error', 'VElement > VExpressionContainer CallExpression']}">
 
diff --git a/tests/lib/rules/no-restricted-syntax.js b/tests/lib/rules/no-restricted-syntax.js
index 3a5868e09..3fcdbc24a 100644
--- a/tests/lib/rules/no-restricted-syntax.js
+++ b/tests/lib/rules/no-restricted-syntax.js
@@ -49,7 +49,7 @@ tester.run('no-restricted-syntax', rule, {
       ]
     },
 
-    // Forbind call expressions on mustache interpolation
+    // Forbids call expressions inside mustache interpolation.
     {
       code: `
         <template>
@@ -60,26 +60,26 @@ tester.run('no-restricted-syntax', rule, {
       options: [
         {
           'selector': 'VElement > VExpressionContainer CallExpression',
-          'message': 'Call expressions are not allowed on mustache interpolation.'
+          'message': 'Call expressions are not allowed inside mustache interpolation.'
         }
       ],
       errors: [
         {
-          message: 'Call expressions are not allowed on mustache interpolation.',
+          message: 'Call expressions are not allowed inside mustache interpolation.',
           line: 3,
           column: 20,
           endLine: 3,
           endColumn: 25
         },
         {
-          message: 'Call expressions are not allowed on mustache interpolation.',
+          message: 'Call expressions are not allowed inside mustache interpolation.',
           line: 4,
           column: 20,
           endLine: 4,
           endColumn: 29
         },
         {
-          message: 'Call expressions are not allowed on mustache interpolation.',
+          message: 'Call expressions are not allowed inside mustache interpolation.',
           line: 5,
           column: 20,
           endLine: 5,