Skip to content

Commit 5cf5c8b

Browse files
Jinjiangchrisvfritz
authored andcommitted
Decoupled video player from Vimeo (#1374)
1 parent ef9c590 commit 5cf5c8b

File tree

2 files changed

+8
-6
lines changed

2 files changed

+8
-6
lines changed

Diff for: themes/vue/layout/index.ejs

+1-1
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,7 @@
8282
</div>
8383

8484
<div id="video-modal" class="modal">
85-
<div class="vimeo-space" style="padding: 56.25% 0 0 0; position: relative;"><iframe src="https://player.vimeo.com/video/247494684" style="height: 100%; left: 0; position: absolute; top: 0; width: 100%;" frameborder="0" webkitallowfullscreen mozallowfullscreen allowfullscreen></iframe></div><script src="https://player.vimeo.com/api/player.js"></script>
85+
<div class="video-space" style="padding: 56.25% 0 0 0; position: relative;"><iframe src="https://player.vimeo.com/video/247494684" style="height: 100%; left: 0; position: absolute; top: 0; width: 100%;" frameborder="0" webkitallowfullscreen mozallowfullscreen allowfullscreen></iframe></div><script src="https://player.vimeo.com/api/player.js"></script>
8686
</div>
8787

8888
<script>

Diff for: themes/vue/source/js/common.js

+7-5
Original file line numberDiff line numberDiff line change
@@ -144,16 +144,18 @@
144144
* Modal Video Player
145145
*/
146146
function initVideoModal () {
147-
if (typeof Vimeo === 'undefined') return
148-
149147
var modalButton = document.getElementById('modal-player')
150148
var videoModal = document.getElementById('video-modal')
151-
var iframe = document.querySelector('iframe');
152-
var player = new Vimeo.Player(iframe);
149+
150+
if (!modalButton || !videoWrapper) {
151+
return
152+
}
153+
154+
var iframe = document.querySelector('iframe')
155+
var player = new Vimeo.Player(iframe)
153156
var overlay = document.createElement('div')
154157
overlay.className = 'overlay'
155158

156-
157159
modalButton.addEventListener('click', function(event) {
158160
event.stopPropagation()
159161
videoModal.classList.toggle('open')

0 commit comments

Comments
 (0)