Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong documentation for .sync modifier #1721

Closed
AmberByte opened this issue Jul 25, 2018 · 2 comments
Closed

Wrong documentation for .sync modifier #1721

AmberByte opened this issue Jul 25, 2018 · 2 comments

Comments

@AmberByte
Copy link

AmberByte commented Jul 25, 2018

There is an error in the vue.js documentation for the .sync modifier you can find here:
https://vuejs.org/v2/guide/components-custom-events.html#sync-Modifier

It states, that you should use a kebab-case event name for the .sync event:

That’s why instead, we recommend emitting events in the pattern of update:my-prop-name. `

This is not correct. because the event must be camelCased to work properly.

@DonNicoJs
Copy link

Also discussed here vuejs/vue#6428
and here: vuejs/vue#8244

@chrisvfritz
Copy link
Contributor

Just updated for now, but once this is merged and released, I'll be changing it back. 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants