Skip to content

Commit 611b892

Browse files
authored
refactor(webdriverio)!: don't include sync API support by default (#6695)
1 parent 17081b7 commit 611b892

File tree

5 files changed

+15
-8
lines changed

5 files changed

+15
-8
lines changed

Diff for: packages/@vue/cli-plugin-e2e-webdriverio/generator/template/tests/e2e/pageobjects/app.page.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,8 @@ class App {
77
/**
88
* methods
99
*/
10-
open (path = '/') {
11-
browser.url(path)
10+
async open (path = '/') {
11+
await browser.url(path)
1212
}
1313
}
1414

Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
<%- hasTS ? 'import App from \'../pageobjects/app.page\'' : 'const App = require(\'../pageobjects/app.page\')' %>
22

33
describe('Vue.js app', () => {
4-
it('should open and render', () => {
5-
App.open()
6-
expect(App.heading).toHaveText('Welcome to Your Vue.js <%- hasTS ? '+ TypeScript ' : '' %>App')
4+
it('should open and render', async () => {
5+
await App.open()
6+
await expect(App.heading).toHaveText('Welcome to Your Vue.js <%- hasTS ? '+ TypeScript ' : '' %>App')
77
})
88
})

Diff for: packages/@vue/cli-plugin-e2e-webdriverio/index.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -49,8 +49,8 @@ module.exports = (api, options) => {
4949
info(`Start WebdriverIO: $ wdio ${runArgs.join(' ')}`)
5050
const runner = execa(wdioBinPath, runArgs, { stdio: 'inherit' })
5151
if (server) {
52-
runner.on('exit', () => server.close())
53-
runner.on('error', () => server.close())
52+
runner.on('exit', () => server.stop())
53+
runner.on('error', () => server.stop())
5454
}
5555

5656
if (process.env.VUE_CLI_TEST) {

Diff for: packages/@vue/cli-plugin-e2e-webdriverio/migrator/index.js

+8
Original file line numberDiff line numberDiff line change
@@ -17,4 +17,12 @@ module.exports = (api) => {
1717
}
1818
})
1919
}
20+
21+
if (api.fromVersion('<= 5.0.0-beta.4')) {
22+
api.extendPackage({
23+
devDependencies: {
24+
'@wdio/sync': '^7.0.7'
25+
}
26+
})
27+
}
2028
}

Diff for: packages/@vue/cli-plugin-e2e-webdriverio/package.json

-1
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,6 @@
3232
"@wdio/mocha-framework": "^7.0.7",
3333
"@wdio/sauce-service": "^7.0.7",
3434
"@wdio/spec-reporter": "^7.0.7",
35-
"@wdio/sync": "^7.0.7",
3635
"eslint-plugin-wdio": "^7.0.0",
3736
"webdriverio": "^7.0.7"
3837
},

0 commit comments

Comments
 (0)