Skip to content

Would you consider using the incremental watch API in fork-ts-checker-webpack-plugin? #3295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
johnnyreilly opened this issue Jan 14, 2019 · 3 comments

Comments

@johnnyreilly
Copy link

What problem does this feature solve?

Faster feedback from the TypeScript compiler.

What does the proposed API look like?

This isn't a bug report - more a heads up. There's a new feature been added to the fork-ts-checker-webpack-plugin (which I believe CRA uses for TypeScript builds). This feature speeds up incremental compilation.

More details can be found here:

https://blog.johnnyreilly.com/2019/01/typescript-and-webpack-watch-it.html

Would you consider upgrading to this for the performance improvement?

See also: TypeStrong/fork-ts-checker-webpack-plugin#198
And: TypeStrong/fork-ts-checker-webpack-plugin#196

@LinusBorg
Copy link
Member

LinusBorg commented Jan 14, 2019

Sounds really good. But even if 1.0.0-alpha* doesn't bring any breaking changes (which I didn'T check so far), I don't think we can/want to use an alpüha release as a dependency of @vue/cli-plugin-typescript. So we would havr to wait for 1.0.0 or at the least, an -rc release.

If you want to give it a spin today, though - you can install it to use yarn's resolve feature to make the plugin resolve to this version, then enable the option via vue.config.js

@johnnyreilly
Copy link
Author

johnnyreilly commented Jan 14, 2019

Yes, no doubt you are thinking "wait, just hold on a minute.... he said @next - I am not that bleeding edge." Well, it's not like that. Don't be scared.

fork-ts-checker-webpack-plugin has merely been updated for webpack 5 (which is in alpha) and the @next reflects that. To be clear, the @next version of the plugin still supports (remarkably!) webpack 2, 3 and 4 as well as 5 alpha. Users of current and historic versions of webpack should feel safe using the @next version; for webpack 2, 3 and 4 expect stability. webpack 5 users should expect potential changes to align with webpack 5 as it progresses.

I'm not actually a Vue user myself but interest was expressed and so I wanted to share the information.

@LinusBorg
Copy link
Member

Hey, thanks! That sounds good, we'll make sure to test it. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants