Skip to content

Add cli-plugin-unit-ava #883

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
brandon93s opened this issue Feb 25, 2018 · 10 comments
Closed

Add cli-plugin-unit-ava #883

brandon93s opened this issue Feb 25, 2018 · 10 comments

Comments

@brandon93s
Copy link

brandon93s commented Feb 25, 2018

What problem does this feature solve?

AVA test runner.

Add unit-ava in addition to the existing unit-mocha and unit-jest core plugins. unit-ava would be exposed in the same way as jest and mocha support and given as an option for unit testing configuration.

What does the proposed API look like?

The API / implementation would follow the pattern(s) established by unit-jest and unit-mocha.

@brandon93s
Copy link
Author

I'm glad to work on this and submit a PR, but wanted to check if it would be accepted into core before proceeding. If not, I can build it as a standalone plugin.

Thanks!

@corbinu
Copy link

corbinu commented Feb 26, 2018

I would love to see this. Happy to help with getting it working with the TypeScript plugin as I am using ava and TypeScript with my own custom template for version 2

@LinusBorg
Copy link
Member

LinusBorg commented Feb 26, 2018

How is the testing story with .vue files with ava these days?

/ping @eddyerburgh tested ava some time ago and performance of existing solutions to transpile .vue files in ava were disappointing, to say the least.

Generelly I don't think we want to add every testing framework as a core pluin, just like we won't add every preprocessor and every compile-to-js language to it (no coffeescript! :-P)

So in order for a PR to be accepted, this proposition would have to:

  1. Provide a great testing experience with Vue, especially .vue files
  2. Gather enough support from the community to make clear using ava with Vue has enough support to add it as a core plugin.

If that doesn't happen, you can ofg course make it a "normal" plugin to the cli, which means users would simpl have to do this to add ava after the initial vue create setup:

npm i -D vue-cli-plugin-ava
vue invoke ava

@yyx990803
Copy link
Member

I'd encourage working on a standalone plugin for Ava first, as it would:

  • Help us gauge the feasibility of the current plugin API for making standalone plugins. In particular, is there any blockers for a 3rd party plugin to play nicely with built-in ones.

  • Lower barrier to get started, as you are free to experiment with the plugin without having to adhere to all the requirements we have for built-in plugins.

If it proves successful for Ava users, we'd be happy to consider pulling it into core.

@corbinu
Copy link

corbinu commented Mar 1, 2018

@yyx990803 That makes sense to me

@brandon93s Did you want any help on this? I am also going to start working on a testcafe plugin as cypress doesn't have support for any browsers other than chrome.

@brandon93s
Copy link
Author

@corbinu - I've got a plugin started locally with the early stages of an implementation working. I'll get it pushed up to GitHub in the next few days so that we can collaborate.

@corbinu
Copy link

corbinu commented Mar 1, 2018

@brandon93s sounds great!

@MartinMuzatko
Copy link

I would love to see ava being an option for testing for Vue. I have no particular experience with testing Vue apps with ava, but ava has been very comfortable to work with and allows for a great testing experience. From personal experience, performance is okayish depending on project size. But I hear that from many sources.

What makes me stick with ava, is that the way tests can be described and organized (and quickly disabled/enabled/test only), is what makes testing so easy with ava.

@yyx990803
Copy link
Member

Closing in favor of a community plugin. Too many built-in choices increase both maintenance debt for us and decision fatigue for users.

@dnlup
Copy link

dnlup commented Apr 8, 2019

I am developing a plugin, if anyone would like to try it and give me some feedback here is the repo:
https://github.com/dnlup/vue-cli-plugin-unit-ava

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants